-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Jetpack: Add filter for avoiding initalization #22553
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
c928a62
to
3258dc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Introduces a method
should_initialize
on the initializer withjetpack_my_jetpack_should_initialize
filter.Changes proposed in this Pull Request:
should_initialize
on the initializer..jetpack_my_jetpack_should_initialize
for avoiding initalizationFor Rationale, see the request for comments on this P2 p1HpG7-eqp-p2
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
JETPACK_ENABLE_MY_JETPACK
and confirm the menu disappears. Set it back.add_filter( 'jetpack_my_jetpack_should_initialize', '__return_false')
and confirm My Jetpack does not load.