Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: update package #22560

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Search: update package #22560

merged 1 commit into from
Jan 31, 2022

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jan 31, 2022

See #22557

Changes proposed in this Pull Request:

  • Let's release a new version of the Search package with the fix, so we can include it in the Jetpack 10.6.
  • This change is a cherry-pick from 903cce1, which was already committed to the release branch.

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Is CI happy?

@jeherve jeherve requested a review from a team as a code owner January 31, 2022 09:49
@jeherve jeherve added this to the jetpack/10.6 milestone Jan 31, 2022
@jeherve jeherve added Instant Search [Feature] Search For all things related to Search [Package] Search Contains core Search functionality for Jetpack and Search plugins [Type] Janitorial labels Jan 31, 2022
@jeherve jeherve self-assigned this Jan 31, 2022
@jeherve jeherve added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jan 31, 2022
@jeherve jeherve mentioned this pull request Jan 31, 2022
Merged
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jan 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: February 1, 2022.
  • Scheduled code freeze: January 24, 2022.

@jeherve jeherve enabled auto-merge (squash) January 31, 2022 10:02
brbrr
brbrr approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeherve jeherve merged commit 832da50 into master Jan 31, 2022
@jeherve jeherve deleted the update/search-package-106 branch January 31, 2022 10:04
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jan 31, 2022
jeherve added a commit to Automattic/jetpack-search that referenced this pull request Jan 31, 2022
@jeherve
Manually release version 0.5.4
f1d95d6 
Related PRs:

- Automattic/jetpack#22557
- Automattic/jetpack#22560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brbrr brbrr brbrr approved these changes

@samiff samiff Awaiting requested review from samiff

@sdixon194 sdixon194 Awaiting requested review from sdixon194

Assignees

@jeherve jeherve

Labels
[Feature] Search For all things related to Search [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Janitorial
Projects
None yet
Milestone
jetpack/10.6
Development

Successfully merging this pull request may close these issues.
2 participants
@jeherve @brbrr