Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Lazy Loading images #22566

Merged
merged 5 commits into from
Feb 3, 2022
Merged

Fix: Lazy Loading images #22566

merged 5 commits into from
Feb 3, 2022

Conversation

pyronaur
Copy link
Member

@pyronaur pyronaur commented Jan 31, 2022

Fixes #22542

Sync Jetpack and Jetpack Boost lazy image status so that toggles in both dashboards always reflect the current status.

Modified the logic slightly. Because Jetpack is watching for filters and reflecting that to the dashboard, I decided to just use Jetpack plugin as the single source of truth instead of Jetpack Boost for the lazy images setting.

Does this pull request change what data or activity we track or use?
No

Testing instructions:
Run E2E Tests

@github-actions github-actions bot added [Plugin] Boost A feature to speed up the site and improve performance. [Focus] Compatibility Ensuring our products play well with third-parties labels Jan 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Boost plugin:

  • Next scheduled release: March 1, 2022.
  • Scheduled code freeze: February 21, 2022.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 31, 2022
Copy link
Member

@thingalon thingalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing to fix, but otherwise looks good. Hadn't thought of using a compatibility module. That's not a bad idea.

Don't forget to use the full Jetpack Monorepo PR template, to assure the gardening and labelling system you've thought about its questions.

* Forward all lazy image settings changes to Jetpack
* when interacting with Jetpack Boost dashboard.
*/
function lazy_imasges_sync_status( $_unused, $new_value ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imasges

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derp 🤪

@pyronaur pyronaur self-assigned this Feb 2, 2022
Copy link
Member

@thingalon thingalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it.

@pyronaur pyronaur merged commit ff3ce45 into master Feb 3, 2022
@pyronaur pyronaur deleted the boost/fix/lazy-loading branch February 3, 2022 08:32
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Boost Feature] Lazy Images E2E Tests [Focus] Compatibility Ensuring our products play well with third-parties [Plugin] Boost A feature to speed up the site and improve performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reinstate Jetpack / Boost Lazy-Loading sync
2 participants