-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Lazy Loading images #22566
Fix: Lazy Loading images #22566
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Boost plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing to fix, but otherwise looks good. Hadn't thought of using a compatibility module. That's not a bad idea.
Don't forget to use the full Jetpack Monorepo PR template, to assure the gardening and labelling system you've thought about its questions.
* Forward all lazy image settings changes to Jetpack | ||
* when interacting with Jetpack Boost dashboard. | ||
*/ | ||
function lazy_imasges_sync_status( $_unused, $new_value ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imasges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
derp 🤪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it.
Fixes #22542
Sync Jetpack and Jetpack Boost lazy image status so that toggles in both dashboards always reflect the current status.
Modified the logic slightly. Because Jetpack is watching for filters and reflecting that to the dashboard, I decided to just use Jetpack plugin as the single source of truth instead of Jetpack Boost for the lazy images setting.
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Run E2E Tests