Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Fix gap between product cards #22577

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

renatoagds
Copy link
Contributor

Fixing the gap between the ProductCard components into ProductCardsSection

Changes proposed in this Pull Request:

  • Update horizontalSpacing and horizontalGap in ProductCardsSection.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Build My Jetpack (jetpack build packages/my-jetpack)
  • Open My Jetpack page.
  • Check the gap between the ProductCard components

@renatoagds renatoagds added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jan 31, 2022
@renatoagds renatoagds added this to the My Jetpack MVP milestone Jan 31, 2022
@renatoagds renatoagds requested a review from a team January 31, 2022 20:08
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Copy link
Contributor

@retrofox retrofox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

before
image
after
image

LGTM 🚀

@retrofox retrofox added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 31, 2022
@renatoagds renatoagds merged commit 0ece064 into master Jan 31, 2022
@renatoagds renatoagds deleted the update/my-jetpack-product-cards-gap branch January 31, 2022 20:59
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants