Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Add react-router for route handling #22585

Merged
merged 4 commits into from
Feb 1, 2022

Conversation

renatoagds
Copy link
Contributor

@renatoagds renatoagds commented Jan 31, 2022

Implement the route system inside My Jetpack, with a hook to block direct navigation to the component.

Changes proposed in this Pull Request:

  • Setup HashRouter and Routes.
  • Include useRouteBlocker that blocks direct route access for some component, it will only be allowed if coming from other router.

Jetpack product discussion

p1643660572899069-slack-C02TQF5VAJD

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Goes into MyJetpackScreen component
  • Insert a Link component from react-router-dom any place, and set the to for /new route.
  • Build My Jetpack (jetpack build packages/my-jetpack).
  • Navigate to My Jetpack.
  • Click in the Link.
  • It should load the New screen.
  • Go back and try to go forward.
  • It will redirect you back to the My Jetpack screen.
  • Click on the link again.
  • Refresh the page.
  • It will redirect you back to the My Jetpack screen.

Demo

route-blocker-example.mp4

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello renatoagds! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D74125-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 31, 2022
@renatoagds renatoagds added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 31, 2022
@renatoagds renatoagds added this to the My Jetpack MVP milestone Jan 31, 2022
@renatoagds renatoagds requested a review from a team January 31, 2022 23:29
@renatoagds renatoagds self-assigned this Jan 31, 2022
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests exactly as described 🚢

@oskosk oskosk enabled auto-merge (squash) February 1, 2022 12:06
@oskosk oskosk merged commit e8c9c80 into master Feb 1, 2022
@oskosk oskosk deleted the update/my-jetpack-routes branch February 1, 2022 12:09
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Great news! One last step: head over to your WordPress.com diff, D74125-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Feb 1, 2022
@anomiex
Copy link
Contributor

anomiex commented Feb 2, 2022

r239427-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants