-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Jetpack: Add react-router for route handling #22585
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests exactly as described 🚢
Great news! One last step: head over to your WordPress.com diff, D74125-code, and commit it. Thank you! |
r239427-wpcom |
Implement the route system inside My Jetpack, with a hook to block direct navigation to the component.
Changes proposed in this Pull Request:
HashRouter
andRoutes
.useRouteBlocker
that blocks direct route access for some component, it will only be allowed if coming from other router.Jetpack product discussion
p1643660572899069-slack-C02TQF5VAJD
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
MyJetpackScreen
componentLink
component fromreact-router-dom
any place, and set theto
for/new
route.My Jetpack
(jetpack build packages/my-jetpack
).My Jetpack
.Link
.New
screen.My Jetpack
screen.My Jetpack
screen.Demo
route-blocker-example.mp4