Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codesniffer: Update wp-coding-standards/wpcs to dev-develop #22600

Merged
merged 8 commits into from
Feb 2, 2022

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Feb 1, 2022

Changes proposed in this Pull Request:

They haven't done a release in over a year, and we need fixes for
errors in PHP 8.0 and 8.1.

This also necessitates a few fixes to existing files and updating of
ignore comments for a renamed sniff.

Jetpack product discussion

p1643730608109909/1643729010.995529-slack-C01U2KGS2PQ

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Is CI happy?
  • Try linting files that were crashing phpcs before. Is it happy now?

They haven't done a release in over a year, and we need fixes for
errors in PHP 8.0 and 8.1.

This also necessitates a few fixes to existing files and updating of
ignore comments for a renamed sniff.
@anomiex anomiex added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Feb 1, 2022
@anomiex anomiex requested a review from jeherve February 1, 2022 17:04
@anomiex anomiex self-assigned this Feb 1, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello anomiex! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D74193-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: March 1, 2022.
  • Scheduled code freeze: February 22, 2022.

jeherve
jeherve previously requested changes Feb 2, 2022
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need to rebase after #22603

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 2, 2022
@anomiex anomiex added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 2, 2022
Copy link
Contributor

@sdixon194 sdixon194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to composer install again but this fixes the error for me 👍

@sdixon194 sdixon194 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 2, 2022
@anomiex anomiex merged commit 4a9a5c1 into master Feb 2, 2022
@anomiex anomiex deleted the update/wpcs-to-dev-branch branch February 2, 2022 22:00
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 2, 2022
@github-actions github-actions bot added this to the jetpack/10.7 milestone Feb 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

Great news! One last step: head over to your WordPress.com diff, D74193-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@anomiex
Copy link
Contributor Author

anomiex commented Feb 2, 2022

r239466-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants