Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPress: Change the default for the "usesAverageColor" setting to True #22608

Merged
merged 4 commits into from
Feb 7, 2022

Conversation

jgcaruso
Copy link
Contributor

@jgcaruso jgcaruso commented Feb 1, 2022

Fixes # 1104-gh-Automattic/greenhouse

This PR changes the default value for the "usesAverageColor" setting (appears as "Match video" under the Progress Bar Colors menu) to true from false since now that its been tested manually for a while we want to make the default behaviour.

Changes proposed in this Pull Request:

  • Default value for the usesAverageColor changed to true
  • Deprecation created since this changes the url of the video embed that gets created

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Nope

Testing instructions:

  • Don't apply the PR yet
  • ensure jetpack is built jetpack build plugins/jetpack
  • Create a new /video block and ensure the Progress Bar Colors -> Match video setting is disabled
  • Create another new /video block and turn on the Progress Bar Colors -> Match video setting
  • Publish the page
  • Checkout this branch
  • rebuild jetpack jetpack build plugins/jetpack
  • reload the page
  • Both players should render correctly without any errors
  • Create a new /video block, the Progress Bar Colors -> Match video setting should be on be default

@jgcaruso jgcaruso added [Feature] VideoPress A feature to help you upload and insert videos on your site. [Status] Needs Team Review labels Feb 1, 2022
@jgcaruso jgcaruso self-assigned this Feb 1, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jgcaruso! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D74216-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Block] VideoPress [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Feb 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: March 1, 2022.
  • Scheduled code freeze: February 22, 2022.

@jgcaruso jgcaruso changed the title [wip] VideoPress: Change the default for the "usesAverageColor" setting to True VideoPress: Change the default for the "usesAverageColor" setting to True Feb 2, 2022
Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well! Thanks for dealing with the deprecation stuff 😵‍💫

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tests well for me. 🚢

@jeherve jeherve added this to the jetpack/10.7 milestone Feb 7, 2022
@jeherve jeherve added the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 7, 2022
@jgcaruso jgcaruso merged commit 88ed8df into master Feb 7, 2022
@jgcaruso jgcaruso deleted the update/videopress-default-progress-colour-option branch February 7, 2022 14:08
@github-actions github-actions bot removed [Status] Ready to Merge Go ahead, you can push that green button! [Status] Needs Team Review labels Feb 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

Great news! One last step: head over to your WordPress.com diff, D74216-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@jgcaruso
Copy link
Contributor Author

jgcaruso commented Feb 7, 2022

Changeset ID: 239672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] VideoPress [Feature] VideoPress A feature to help you upload and insert videos on your site. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants