Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Adding Connection Screen #22609

Merged
merged 5 commits into from
Feb 2, 2022

Conversation

renatoagds
Copy link
Contributor

Related with #22291

Changes proposed in this Pull Request:

  • Adding ConnectionScreen component.
  • Adding connection route.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Goes into MyJetpackScreen component
  • Insert a Link component from react-router-dom any place, and set the to for /connection route.
  • Build My Jetpack (jetpack build packages/my-jetpack).
  • Navigate to Dashboard
  • Disconnect Jetpack
  • Reconnect it, but doesn't connect wpcom account.
  • Navigate to My Jetpack.
  • Click in the Link.
  • It should load the ConnectionScreen screen.
  • Click in Connect your user account, it should start connection flow.

⚠️ Layout Warnings

Some points in the current screen are different from Figma, basic these points:

  • It implements Go back instead X button, which aligns better with products flow (we can discuss it later).
  • Connect button is blue instead black.
  • Bottom descriptions don't include the list of services to connect with.
  • Missing And more! See all Jetpack features list item.

Most of them will be implemented in the upcoming PRs.

Demo

connection-screen.mp4

@renatoagds renatoagds added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Feb 1, 2022
@renatoagds renatoagds self-assigned this Feb 1, 2022
@renatoagds renatoagds requested a review from a team February 1, 2022 21:47
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@renatoagds renatoagds added this to the My Jetpack MVP milestone Feb 1, 2022
@renatoagds renatoagds changed the title My Jetpack: Adding Connect Screen My Jetpack: Adding Connection Screen Feb 1, 2022
oskosk
oskosk previously approved these changes Feb 2, 2022
@renatoagds renatoagds enabled auto-merge (squash) February 2, 2022 16:31
@renatoagds renatoagds added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 2, 2022
@renatoagds renatoagds merged commit b22e4e8 into master Feb 2, 2022
@renatoagds renatoagds deleted the update/my-jetpack-connection-screen branch February 2, 2022 16:51
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants