Premium content: Improve editing consistency

[dsas]

In the editor, viewing the content for people who don't have a
subscription is sometimes referred to as 'Visitor view' and sometimes as
'Logged out view'. This change makes the interface more consistent by using 'Guest View'.

Swap order of visitor/subscriber buttons in the editor to match the
order of the added content.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

1. Apply patch - on simple by using the generated wpcom diff, or using a jurassic ninja and jp beta with feature branch
2. Create a new post
3. Insert a premium content block

Thing	Before	After
Block toolbar
List view

Fixes #22425

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello dsas! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D74272-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Jetpack plugin:

• Next scheduled release: March 1, 2022.
• Scheduled code freeze: February 22, 2022.

[BogdanUngureanu]

Great work Dean, it tests well on both Atomic and Simple. There's one thing that looks a bit unexpected though: now, the default selected tab is the one from right (Guest View), which is not common pattern. Maybe we switch order of the blocks?

[dsas]

Oh, good eye for detail 👏 @BogdanUngureanu

I've made that change so that it's consistent.

To me the subscriber content is the primary thing someone might want to work on next, so I thought about making the subscriber view the default and first one. The visitor guest content already has a good placeholder and probably isn't what you're excited about writing about. I've stuck with the existing flow though - visitor view first, as maybe someone has thought more than me about this in the past, and to avoid disrupting existing users.

[BogdanUngureanu]

Works as expected! 🥳

To me the subscriber content is the primary thing someone might want to work on next, so I thought about making the subscriber view the default and first one. The visitor guest content already has a good placeholder and probably isn't what you're excited about writing about. I've stuck with the existing flow though - visitor view first, as maybe someone has thought more than me about this in the past, and to avoid disrupting existing users.

Having the content as makes more sense to me too, but I think we should keep the current behaviour for now.

[Copons]

I don't have anything against it, but is there a reason why we settled on "Guest" instead of picking one of the existing options? 😄

I'd say "guest" is a fairly reasonable label, although I wonder if by keeping, say, "Visitor" we'd also keep its translation instead of possibly needing a new one.

(Randomly pinging @apeatling for opinions, because, as per tradition, all blames end with him. )

[dsas]

I don't have anything against it, but is there a reason why we settled on "Guest" instead of picking one of the existing options?

It's traditional when there are two competing standards to unify them by creating another

"Logged Out view" seemed a bit unwieldy to me, I didn't like "Visitor view" because everywhere else on WPcom (stats, dashboard, repeat visitor block) 'Visitor' is just any website viewer, whether subscribed or not. Guest just seemed to get over the idea better to me.

Though now I think about it, 'Guest' isn't strictly accurate as you could be contributing on one plan, but this premium content is gated behind a different plan 🤷‍♂️. Happy to go back to Visitor if that's preferred.

[dsas]

Maybe changing to "Content" and something like "Payment prompt" or just "Paywall" makes more sense.

[Copons]

@dsas Of all the suggestions, Guest View sounds best to me 😄
Though, I've added a Needs Copy Review in the off-chance editorial folks have another idea.

Either way, I think this is ready to go once we get the JP ✅ .
We can revisit the label at a later date if needed.

[github-actions]

Great news! One last step: head over to your WordPress.com diff, D74272-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

[dsas]

Changeset r239595-wpcom