Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Fire Tracks events for click on product add link #22629

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

oskosk
Copy link
Contributor

@oskosk oskosk commented Feb 2, 2022

Adds tracking for clicks on add links for product cards.

Changes proposed in this Pull Request:

  • Introduces function addHandler that will call the passed prop onAdd after firing Tracks event.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Introduces 1 new event:

  • jetpack_myjetpack_product_card_add_click fired when the user clicks on a product card add link

Testing instructions:

  • Checkout this branch on a site with Jetpack connected the Backup plugin active, and the JETPACK_ENABLE_MY_JETPACK constant set to true.
  • Open the browser and visit the site's wp-admin.
  • Open the developer console, execute the following code: localStorage.debug='dops:analyitics*
  • Go to "Jetpack -> My Jetpack", Confirm that the developer console displays the events jetpack_myjetpack_product_card_add_click ` when clicking such link from the CRM product card for example.

@oskosk oskosk added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Feature] Tracks [Package] My Jetpack labels Feb 2, 2022
@oskosk oskosk added this to the My Jetpack MVP milestone Feb 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@oskosk oskosk requested a review from a team February 2, 2022 21:41
Copy link
Contributor

@retrofox retrofox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@retrofox retrofox added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 2, 2022
@oskosk oskosk merged commit 9ea6026 into master Feb 2, 2022
@oskosk oskosk deleted the add/record-event-for-on-add branch February 2, 2022 21:42
@oskosk
Copy link
Contributor Author

oskosk commented Feb 2, 2022

Gracia!

@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants