Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My Jetpack: expose pricing product data #22630

Merged
merged 5 commits into from
Feb 3, 2022
Merged

My Jetpack: expose pricing product data #22630

merged 5 commits into from
Feb 3, 2022

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Feb 2, 2022 •
edited
Loading

This PR exposes the pricing data for each product, adding the get_pricing_for_ui() static method to the Product class. We can define the way that we are going to get and propagate these data. Hardcoding vs pulling from wpcom.
The data provided should be enough to show the following price section of the Product card:

Screen Shot 2022-02-02 at 6 18 01 PM

Fixes #

Changes proposed in this Pull Request:

  • My Jetpack: expose pricing product data

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to My Jetpack page
  • Check the Product items taking a look at the items:
myJetpackInitialState.products.items

image

@retrofox retrofox added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Size] S [Package] My Jetpack labels Feb 2, 2022
@retrofox retrofox requested review from leogermani and a team February 2, 2022 21:28
@retrofox retrofox self-assigned this Feb 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@retrofox retrofox force-pushed the update/my-jetpack-add-pricing-harcoded-product-data branch from 9b7b5a7 to 9bb618f Compare February 2, 2022 21:53
@retrofox retrofox added [Status] In Progress and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 2, 2022
@retrofox retrofox force-pushed the update/my-jetpack-add-pricing-harcoded-product-data branch from 9bb618f to 4c2f32c Compare February 3, 2022 11:35
@retrofox retrofox added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Feb 3, 2022
@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 3, 2022
@sdixon194 sdixon194 added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 3, 2022
@sdixon194
Copy link
Contributor

Looks like some PHP errors might need to be cleaned up before it can be merged.

renatoagds
renatoagds previously requested changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@renatoagds renatoagds left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing review, based on @sdixon194 comment

@renatoagds renatoagds removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 3, 2022
@retrofox retrofox force-pushed the update/my-jetpack-add-pricing-harcoded-product-data branch from 4c2f32c to 5f76110 Compare February 3, 2022 18:22
sdixon194
sdixon194 approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@sdixon194 sdixon194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look to be passing now 👍

@sdixon194 sdixon194 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 3, 2022
@retrofox
Copy link
Contributor Author

retrofox commented Feb 3, 2022

Changing review, based on @sdixon194 comment

I don't get why you are requesting changes here, @renatoagds

The PR was blocked because of some failing tests, already addressed here 5f76110

@sdixon194 sdixon194 dismissed renatoagds’s stale review February 3, 2022 18:44

Failing tests addressed.

@renatoagds
Copy link
Contributor

@retrofox I requested changes at the same time you did a new push, did based on the problems before you fix them.

@retrofox retrofox merged commit 4752c6c into master Feb 3, 2022
@retrofox retrofox deleted the update/my-jetpack-add-pricing-harcoded-product-data branch February 3, 2022 18:55
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 3, 2022
@oskosk oskosk added this to the My Jetpack MVP milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatoagds renatoagds renatoagds approved these changes

@sdixon194 sdixon194 sdixon194 approved these changes

@leogermani leogermani Awaiting requested review from leogermani

Assignees

@retrofox retrofox

Labels
[Package] My Jetpack [Size] S
Projects
None yet
Milestone
My Jetpack MVP
Development

Successfully merging this pull request may close these issues.
4 participants
@retrofox @sdixon194 @renatoagds @oskosk