Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new Plans package #22650

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Create new Plans package #22650

merged 1 commit into from
Feb 3, 2022

Conversation

leogermani
Copy link
Contributor

This PR creates a new package with functionality to fetch Plans data from WPCOM.

For now, it copies the classes from the Jetpack plugin. Usage in the Jetpack plugin will be replaced in subsequent PRs as this must be synced with changes in WPCOM as well.

We need this to move the work on the My Jetpack feature.

Changes proposed in this Pull Request:

  • Create new Plans package

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Nothing for now, the package is not used
  • Let's see if the tests pass

@leogermani leogermani added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Feb 3, 2022
@leogermani leogermani self-assigned this Feb 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@oskosk oskosk added this to the My Jetpack MVP milestone Feb 3, 2022
@oskosk oskosk enabled auto-merge (squash) February 3, 2022 23:01
@oskosk oskosk merged commit 301c0f5 into master Feb 3, 2022
@oskosk oskosk deleted the extract/jetpack-plans branch February 3, 2022 23:01
@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 3, 2022
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 3, 2022
@leogermani leogermani mentioned this pull request Feb 9, 2022
@mkm119
Copy link
Contributor

mkm119 commented Mar 18, 2022

Restoring this branch since we need this package as part of making a standalone Publicize plugin.

Discussion: #23488 (comment)
p1647598368441399/1647597121.990859-slack-CBG1CP4EN

@mkm119 mkm119 restored the extract/jetpack-plans branch March 18, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants