Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Connect Boost card with the interstitial #22656

Merged
merged 4 commits into from
Feb 4, 2022

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Feb 4, 2022

This PR register a new /add-boost route tied to the <BoostInterstitial /> component. Also, Adds a handler to the onAdd() BoostCard property to lead the user to the interstitial page by clicking on the Add Boost link

Note: We are going to add the Go back link in a follow-up.

Fixes #22655

Changes proposed in this Pull Request:

  • My Jetpack: Connect Boost card with the interstitial page via /add-boost root

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Go to My Jetpack
  • Set up in order to do not have Boost available in your dashboard. You can hardcode the get_status() method forcing this plugin_absent status.
  • Confirm you see the interstitial page by clicking on Add Boost link.
Screen.Recording.2022-02-04.at.6.49.26.AM.mov

@retrofox retrofox added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Size] S [Package] My Jetpack labels Feb 4, 2022
@retrofox retrofox requested a review from a team February 4, 2022 09:51
@retrofox retrofox self-assigned this Feb 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well. Tested on JN

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 4, 2022
@oskosk
Copy link
Contributor

oskosk commented Feb 4, 2022

Just pushed a rebase (merge from master)

@oskosk oskosk enabled auto-merge (squash) February 4, 2022 11:59
@oskosk oskosk merged commit be9c645 into master Feb 4, 2022
@oskosk oskosk deleted the update/my-jetpack-open-boost-interstitial branch February 4, 2022 12:12
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 4, 2022
@oskosk oskosk added this to the My Jetpack MVP milestone Feb 4, 2022
@oskosk oskosk mentioned this pull request Feb 8, 2022
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My Jetpack: connect Boost card with interstitial
2 participants