-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Jetpack: Connect Boost card with the interstitial #22656
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well. Tested on JN
Just pushed a rebase (merge from master) |
This PR register a new
/add-boost
route tied to the<BoostInterstitial />
component. Also, Adds a handler to theonAdd()
BoostCard property to lead the user to the interstitial page by clicking on theAdd Boost
linkNote: We are going to add the
Go back link
in a follow-up.Fixes #22655
Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Boost
available in your dashboard. You can hardcode the get_status() method forcing thisplugin_absent
status.Add Boost
link.Screen.Recording.2022-02-04.at.6.49.26.AM.mov