Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: add Search interstitial view #22687

Merged
merged 9 commits into from
Feb 7, 2022

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Feb 4, 2022

  • Changes the product status handling, checking if it requires a paid plan first of all.
  • Adds the <SearchInterstitial /> component
  • Register the /add-search route

Follow-up tasks

  • Compute properly the price of Search 22702
  • Register/reuse a new Jetpack redirect to lead to the checkout page 22701

Fixes #

Changes proposed in this Pull Request:

  • My Jetpack: add Search interstitial view
  • Intrdoduces status NEEDS_PURCHASE.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

With a site without a Search product

  • Go to My Jetpack
  • Confirm you see the Add Search link in the product card

  • Confirm you see the Search interstitial by clicking on the Add Search link

The checkout link is not already implemented :-(

  • Buy the product from the jetpack dashboard
  • Once you buy it, confirm you can activate/deactivate the Search product.
Screen.Recording.2022-02-04.at.6.38.03.PM.mov

@retrofox retrofox added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Size] M [Package] My Jetpack labels Feb 4, 2022
@retrofox retrofox requested a review from a team February 4, 2022 21:36
@retrofox retrofox self-assigned this Feb 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@retrofox retrofox enabled auto-merge (squash) February 4, 2022 21:41
@retrofox retrofox force-pushed the update/my-jetpack-handle-search-product-from-ui branch from 39b06a5 to 80981b8 Compare February 7, 2022 11:15
@retrofox retrofox force-pushed the update/my-jetpack-handle-search-product-from-ui branch from ceaaa26 to 8f0461e Compare February 7, 2022 13:06
@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 7, 2022
@oskosk oskosk added this to the My Jetpack MVP milestone Feb 7, 2022
@retrofox retrofox merged commit 9a0ab28 into master Feb 7, 2022
@retrofox retrofox deleted the update/my-jetpack-handle-search-product-from-ui branch February 7, 2022 13:28
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 7, 2022
@retrofox
Copy link
Contributor Author

retrofox commented Feb 7, 2022

thanks

@oskosk oskosk mentioned this pull request Feb 8, 2022
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants