License Activation Notice: fix issue in license activation notice that appears even after being dismissed

[yashwin]

Fixes 1202619025189113-as-1202655518335358

Changes proposed in this Pull Request:

It fixes an issue in the user license activation notice banner that appears even after being dismissed.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results and verified that your changes do not break them?

Does this pull request change what data or activity we track or use?

No

Testing instructions:

1. Set up a new test site using JN with this branch.
2. Visit the newly created site -> Click on Jetpack nav item -> Activate Jetpack.
3. Go to https://jetpack.com/ and buy any product and skip the site selection.
4. Now, go to your site -> Jetpack(refresh if you are on the same page), and you should see the activation notice with the message Activate <PRODUCT_NAME> ...
5. Now dismiss the notice by clicking on the X icon on the notice and verify that the notice doesn't appear again

Example notice

NOTE: This issue is caused by merging Show product name on activation notice The expected behavior is to hide the notice banner when a user activates a license until a new license is issued; check Display notice when a user has unactivated product license keys for more details.

[coder-karen]

@yashwin I'll be cutting the Beta for Jetpack 11.2 in half an hour - is the intention to have this in the Jetpack 11.2 release?

[yashwin]

@yashwin I'll be cutting the Beta for Jetpack 11.2 in half an hour - is the intention to have this in the Jetpack 11.2 release?

@coder-karen Not really, I would like to release this as early as possible. I have removed the milestone for now.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Jetpack plugin:

• Next scheduled release: September 6, 2022.
• Scheduled code freeze: August 30, 2022.

[rcanepa]

LGTM.

Everything worked as expected, and I couldn't find any regression.

[rcanepa]

LGTM again since nothing changed in terms of logic.

[sdixon194]

👍

[yashwin]

@sdixon194 - Is it ok if I go ahead and merge this?

[sdixon194]

Is it ok if I go ahead and merge this?

Oh yeah! Anytime it has the Ready to Merge label and the approval, you can merge whenever you're ready!

The PR was out of date now, so I just merged with trunk. Assuming all the CI checks pass you can merge when it's done 👍