Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build: Move "Test plugin upgrades" to a post-build workflow" #25894

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Aug 29, 2022

Changes proposed in this Pull Request:

This reverts commit 4883758.

It looks like GitHub has a fairly critical bug (which they've apparently
not cared about for 2 years
) where the check run created from Actions
gets assigned to a random suite. If that random suite happens to be one
of the Gardening runs, it can get lost when the next Gardening run
happens.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

p1661807167941679/1661802332.889069-slack-CDLH4C1UZ

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Things should work as they did before.

…25892)"

This reverts commit 4883758.

It looks like GitHub has a fairly critical bug (which they've apparently
not cared about for 2 years[1]) where the check run created from Actions
gets assigned to a random suite. If that random suite happens to be one
of the Gardening runs, it can get lost when the next Gardening run
happens.

[1]: https://github.com/orgs/community/discussions/24616
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal labels Aug 29, 2022
@anomiex anomiex self-assigned this Aug 29, 2022
Copy link
Contributor

@sdixon194 sdixon194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rip

@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Aug 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@anomiex anomiex enabled auto-merge (squash) August 29, 2022 21:15
@sdixon194 sdixon194 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Aug 29, 2022
@anomiex anomiex merged commit 98d4f03 into trunk Aug 29, 2022
@anomiex anomiex deleted the revert/post-build-workflow branch August 29, 2022 21:35
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants