Subs Widget: better error for when emails has blocked subscriptions #2599
Conversation
dereksmart
added
[Type] Enhancement
dereksmart
added
[Status] Needs Review
|
Not at a computer to adjust the PR, but we could make the language better. "This e-mail address has opted out of subscriptions e-mails. You can adjust this preference at https://subscribe.wordpress.com." or something like that. |
|
sure, but the option could also be set in their "wordpress.com/me/notifications" page under "Block all email updates from blogs you’re following on WordPress.com". |
|
I'm not sure if those are the same or different settings, tbh. The subscribe. site works for any e-mail adr; not wp.com user dependent. |
|
me neither. time to test :) |
|
Confirmed it's the same option in both |
dereksmart
force-pushed
the
enhance/subscription-widget-error-messages
branch
from
d15cd9b to
b53c88b
Compare
dereksmart
force-pushed
the
enhance/subscription-widget-error-messages
branch
from
b53c88b to
ebe840d
Compare
| @@ -734,6 +737,12 @@ function widget( $args, $instance ) { | |||
| case 'invalid_email' : ?> | |||
| <p class="error"><?php esc_html_e( 'The email you entered was invalid. Please check and try again.', 'jetpack' ); ?></p> | |||
| <?php break; | |||
| case 'opted_out' : ?> | |||
| <p class="error"><?php printf( _x( "The email address has opted out of subscription emails. %1s You can manage your preferences at %2s", '%1s is a line break, %2s is a website', 'jetpack' ), | |||
There was a problem hiding this comment.
Let's embed the HTML into translation and only insert links. Also please use a translator comment here instead of context to provide explanations for translation placeholders.
zinigor
added
[Status] In Progress
[Status] Requires String Changes
and removed
[Status] Needs Review
|
Looking good except for the i18n issue. This has my 👍 after fixing |
dereksmart
added
[Status] Ready to Merge
…error-messages Subs Widget: better error for when emails has blocked subscriptions
dereksmart
removed
the
[Status] Ready to Merge
|
I am getting the case 'opted_out' error (The email address has opted out of subscription emails.) when there is no reason for me to be getting that error. The email address is following the particular blog and is not opting out of receiving email notifications, either from the blog or from wordpress.com globally. I actually should be getting the case 'already' error (You have already subscribed to this site.), though. I previously signed up on the blog for subscription, and that sign-up process went fine. Has anyone else reported this? I am certain that I should not be getting first error above, and that I should be getting the second error instead. |
|
@finlanderid Could you contact us via this contact form and let us know your email address, so we can look into this with you? Thanks! |
|
@jeherve: 2416945-t Checked and showing:
|
|
@jeherve https://github.com/jeherve: 2416945-t exactly, that's why it's odd that I get the: subscription emails.") instead of the: site.") when I attempt to subscribe with an email address that is already On 11/13/2015 3:28 PM, Carolyn Sonnek wrote:
|
|
@finlanderid I replied to your email a few minutes ago. Thanks for the extra details. |
Fixes #2007
To test:
append this to a url that has the subscription widget
?subscribe=opted_out