Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subscription block] Add social followers toggle #27443

Merged
merged 22 commits into from
Nov 30, 2022

Conversation

TimBroddin
Copy link
Contributor

@TimBroddin TimBroddin commented Nov 16, 2022

Changes proposed in this Pull Request:

This PR adds a toggle to the Subscription block settings, that allows to toggle between including social followers (default) in the count, or excluding them.

CleanShot 2022-11-16 at 16 02 36@2x

Jetpack product discussion
pdDOJh-ZI-p2
pdDOJh-Yp-p2

Does this pull request change what data or activity we track or use?
No

Testing instructions:

  1. Apply this PR
  2. The checkbox should be visible & toggling it should update the number in both editor & frontend.

To test with simple sites:

  • On your sandbox:
    • bin/jetpack-downloader test jetpack add/subscription-block-social-toggle(don't checkout trunk)

To test with Atomic:

  • Follow these instructions: pb5gDS-1rQ-p2

Also make sure that users see the same count when upgrading (standard behavior should be to include social followers)

@TimBroddin TimBroddin added [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Block] Subscriptions [Status] Needs Team Review [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Jetpack labels Nov 16, 2022
@TimBroddin TimBroddin self-assigned this Nov 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: December 6, 2022.
  • Scheduled code freeze: November 28, 2022.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack add/subscription-block-social-toggle to get started. More details: p9dueE-5Nn-p2

mashikag
mashikag previously approved these changes Nov 22, 2022
Copy link
Contributor

@mashikag mashikag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine to me.
I tested the PR and the added "include social followers" toggle seems to work as expected. 👍

mashikag jurassic tube_wp-admin_post php_post=73 action=edit calypsoify=1 (1)
mashikag jurassic tube_wp-admin_post php_post=73 action=edit calypsoify=1
Screen Shot 2022-11-22 at 11 08 13

@mashikag mashikag added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Team Review labels Nov 22, 2022
@TimBroddin TimBroddin added [Status] Needs Team Review and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Nov 22, 2022
@TimBroddin
Copy link
Contributor Author

Did some refactoring after seeing that the block & shortcode widget are now decoupled.

This is ready for another team review next week.

Copy link
Contributor

@mashikag mashikag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had another look and the last commit seems to be fixing the issue mentioned by @coder-karen . All looks good to me. 👍

@mashikag mashikag added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Team Review labels Nov 29, 2022
Copy link
Contributor

@bindlegirl bindlegirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bindlegirl bindlegirl added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Nov 30, 2022
@TimBroddin TimBroddin merged commit 4415d93 into trunk Nov 30, 2022
@TimBroddin TimBroddin deleted the add/subscription-block-social-toggle branch November 30, 2022 13:33
@github-actions github-actions bot added this to the jetpack/11.6 milestone Nov 30, 2022
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Subscriptions [Feature] Ad [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Test Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants