Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing: do not include buttons in REST API responses #28412

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Sharing: do not include buttons in REST API responses #28412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91254fd
Sharing: do not include buttons in REST API responses
jeherve Jan 17, 2023
d374c80
Merge branch 'trunk' into update/sharing-rm-api
sergeymitr Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/update-sharing-rm-api
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: bugfix

Sharing: do not include the sharing buttons in REST API responses.
3 changes: 1 addition & 2 deletions projects/plugins/jetpack/modules/sharedaddy/sharing-service.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,8 +959,7 @@ function sharing_display( $text = '', $echo = false ) {
}

// Prevent from rendering sharing buttons in block which is fetched from REST endpoint by editor
if ( defined( 'REST_REQUEST' ) && REST_REQUEST &&
isset( $_GET['context'] ) && 'edit' === $_GET['context'] ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
if ( defined( 'REST_REQUEST' ) && REST_REQUEST ) {
return $text;
}

Expand Down