Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E tests: wait for editor canvas load #28494

Merged
merged 1 commit into from
Jan 20, 2023
Merged

E2E tests: wait for editor canvas load #28494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/e2e-wait-for-editor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: other


1 change: 1 addition & 0 deletions projects/plugins/jetpack/tests/e2e/specs/blocks/free-blocks.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ test.describe.parallel( 'Free blocks', () => {
await test.step( 'Visit block editor page', async () => {
blockEditor = await BlockEditorPage.visit( page );
await blockEditor.resolveWelcomeGuide( false );
await blockEditor.waitForEditor();
} );
} );

Expand Down
1 change: 1 addition & 0 deletions projects/plugins/jetpack/tests/e2e/specs/blocks/pro-blocks.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ test.describe( 'Paid blocks', () => {
await test.step( 'Visit block editor page', async () => {
blockEditor = await BlockEditorPage.visit( page );
await blockEditor.resolveWelcomeGuide( false );
await blockEditor.waitForEditor();
} );
} );

Expand Down
4 changes: 4 additions & 0 deletions tools/e2e-commons/pages/wp-admin/block-editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,4 +150,8 @@ export default class BlockEditorPage extends WpPage {
await this.click( settingsLocator );
}
}

async waitForEditor() {
await this.canvasPage.canvas().waitForSelector( "h1[aria-label='Add title']" );
}
}