Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo gardening: update auto-labeling rules for Boost #28871

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Feb 9, 2023

Proposed changes:

Boost modules were moved to a features/ directory in #22163, but this task wasn't updated accordingly. This should fix things.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • p1675960331034229/1675957795.951349-slack-CBG1CP4EN

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Not much to test here, this will change how labels are applied in future PRs touching Boost features.

Boost modules were moved to a features/ directory in #22163, but this task wasn't updated accordingly. This should fix things.
@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial [Pri] Normal [Action] Repo Gardening Github Action: manage PR and issues in your Open Source project labels Feb 9, 2023
@jeherve jeherve self-assigned this Feb 9, 2023
@jeherve jeherve enabled auto-merge (squash) February 9, 2023 16:37
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Feb 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Copy link
Contributor

@sergeymitr sergeymitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🚢

@sergeymitr sergeymitr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 9, 2023
@jeherve jeherve merged commit c6c2cda into trunk Feb 10, 2023
@jeherve jeherve deleted the update/auto-labeling-boost-features branch February 10, 2023 07:07
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants