Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required-review: Add consume option #29317

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Mar 6, 2023

Proposed changes:

In the monorepo we have a bunch of projects owned by different teams. Everyone should be able to update lock files and changelog entries, which means that the rules for each team's projects has to exclude those files so only the "anyone can update these files" rule applies.

This adds a new rule option, consume. When set on a rule, any paths matching the rule will be ignored for all later rules in the file. This will allow us to not have to repeat these exclusions everywhere.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None. Has been on my list for a long time, and the most recent update made me decide to finally do it.

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Use the test.sh script to run against various PRs, I guess.
  • Check added docs for typos and sense.

In the monorepo we have a bunch of projects owned by different teams.
Everyone should be able to update lock files and changelog entries,
which means that the rules for each team's projects has to exclude those
files so only the "anyone can update these files" rule applies.

This adds a new rule option, `consume`. When set on a rule, any paths
matching the rule will be ignored for all later rules in the file. This
will allow us to not have to repeat these exclusions everywhere.
@anomiex anomiex added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal labels Mar 6, 2023
@anomiex anomiex self-assigned this Mar 6, 2023
@github-actions github-actions bot added [Action] Required Review Actions GitHub actions used to automate some of the work around releases and repository management labels Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@anomiex anomiex mentioned this pull request Mar 6, 2023
3 tasks
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does make sense. I wasn't super sure of the consume name at first, but I cannot come up with anything better, so that's alright I suppose :)

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 7, 2023
@anomiex
Copy link
Contributor Author

anomiex commented Mar 8, 2023

The only other thing I could come up with was "consumePaths" if we want to be a little clearer about what's being consumed.

@jeherve
Copy link
Member

jeherve commented Mar 9, 2023

I'm not considering this a blocker; we can always blame things back to this PR whenever doubts will come up.

@anomiex anomiex merged commit 571659d into trunk Mar 9, 2023
@anomiex anomiex deleted the add/required-review-consume-option branch March 9, 2023 16:17
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Action] Required Review Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants