-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
required-review: Add consume
option
#29317
Conversation
In the monorepo we have a bunch of projects owned by different teams. Everyone should be able to update lock files and changelog entries, which means that the rules for each team's projects has to exclude those files so only the "anyone can update these files" rule applies. This adds a new rule option, `consume`. When set on a rule, any paths matching the rule will be ignored for all later rules in the file. This will allow us to not have to repeat these exclusions everywhere.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does make sense. I wasn't super sure of the consume
name at first, but I cannot come up with anything better, so that's alright I suppose :)
The only other thing I could come up with was "consumePaths" if we want to be a little clearer about what's being consumed. |
I'm not considering this a blocker; we can always |
Proposed changes:
In the monorepo we have a bunch of projects owned by different teams. Everyone should be able to update lock files and changelog entries, which means that the rules for each team's projects has to exclude those files so only the "anyone can update these files" rule applies.
This adds a new rule option,
consume
. When set on a rule, any paths matching the rule will be ignored for all later rules in the file. This will allow us to not have to repeat these exclusions everywhere.Other information:
Jetpack product discussion
None. Has been on my list for a long time, and the most recent update made me decide to finally do it.
Does this pull request change what data or activity we track or use?
No
Testing instructions:
test.sh
script to run against various PRs, I guess.