required-review: Don't fail on case mismatch for @singleuser
pseudo-teams
#29322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
GitHub usernames are case-insensitive but case-preserving. To match that logic, we want
@singleuser
to matchSingleUser
or whatever the actual username is.This is complicated by the fact that "case-insensitive" can vary depending on what exactly GitHub is doing on their end, what version of Unicode they're using, and so on. So let's just ask GitHub's API for the correct casing of the username and use that instead of trying to work out all those edge cases ourself.
Other information:
Jetpack product discussion
#29318 (comment)
Does this pull request change what data or activity we track or use?
No
Testing instructions:
@singleuser
entry in.github/files/required-review.yaml
and using thetest.sh
script to see how it handles an appropriate PR.