Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required-review: Don't fail on case mismatch for @singleuser pseudo-teams #29322

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Mar 6, 2023

Proposed changes:

GitHub usernames are case-insensitive but case-preserving. To match that logic, we want @singleuser to match SingleUser or whatever the actual username is.

This is complicated by the fact that "case-insensitive" can vary depending on what exactly GitHub is doing on their end, what version of Unicode they're using, and so on. So let's just ask GitHub's API for the correct casing of the username and use that instead of trying to work out all those edge cases ourself.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

#29318 (comment)

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Try changing the case of an @singleuser entry in .github/files/required-review.yaml and using the test.sh script to see how it handles an appropriate PR.

…-teams

GitHub usernames are case-insensitive but case-preserving. To match that
logic, we want `@singleuser` to match `SingleUser` or whatever the
actual username is.

This is complicated by the fact that "case-insensitive" can vary
depending on what exactly GitHub is doing on their end, what version of
Unicode they're using, and so on. So let's just ask GitHub's API for the
correct casing of the username and use that instead of trying to work
out all those edge cases ourself.
@anomiex anomiex added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal labels Mar 6, 2023
@anomiex anomiex self-assigned this Mar 6, 2023
@github-actions github-actions bot added [Action] Required Review Actions GitHub actions used to automate some of the work around releases and repository management labels Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 10, 2023
@anomiex anomiex merged commit 07a8db0 into trunk Mar 10, 2023
@anomiex anomiex deleted the fix/required-review-username-case branch March 10, 2023 15:32
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Action] Required Review Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants