Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Review: remove rules except for Sync, Connection, monorepo #29426

Merged
merged 7 commits into from
Mar 11, 2023

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Mar 10, 2023

  • Remove unmatched rule
  • Allow everyone ability to edit docs
  • Reserve Sync and Conneciton packages
  • Allow all to change changelogs, etc
  • Remove all team-specific rules

As part of flipping the script on the review process, allow all a12s to review anything in the repo with the exception of Sync and Connection packages, plus the monorepo tooling itself.

Proposed changes:

  • See above.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?
    n/a

Jetpack product discussion

pdWQjU-fR-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • See if the Required Review check passes when someone not in the Approvers group approves anything outside of the reserved areas mentioned.

@kraftbj kraftbj added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial [Tools] Monorepo Setup labels Mar 10, 2023
@kraftbj kraftbj self-assigned this Mar 10, 2023
@kraftbj kraftbj requested a review from jeherve March 10, 2023 20:10
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Mar 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@anomiex anomiex mentioned this pull request Mar 10, 2023
3 tasks
@kraftbj kraftbj enabled auto-merge (squash) March 10, 2023 22:29
@kraftbj kraftbj merged commit ddf9e08 into trunk Mar 11, 2023
@kraftbj kraftbj deleted the update/required-review-rules branch March 11, 2023 01:24
@anomiex
Copy link
Contributor

anomiex commented Mar 11, 2023

Don't forget to re-enable the check now that it's cut down.

@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Tools] Monorepo Setup [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants