Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds feature where if review requirement not met, then request #30653

Merged
merged 17 commits into from
Jun 13, 2023
Merged

Adds feature where if review requirement not met, then request #30653

merged 17 commits into from
Jun 13, 2023

Commits on May 31, 2023

  1. Adds feature where if review requirement not met, then request

    @gfog-floqast
    gfog-floqast authored and greg.fogelberg@floqast.com committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f52d7e0 View commit details
    Browse the repository at this point in the history

  2. Adds changelog file

    @gfog-floqast
    gfog-floqast authored and greg.fogelberg@floqast.com committed May 31, 2023
    Configuration menu
    Copy the full SHA
    468f0db View commit details
    Browse the repository at this point in the history

  3. updates for eslint

    @gfog-floqast
    gfog-floqast authored and greg.fogelberg@floqast.com committed May 31, 2023
    Configuration menu
    Copy the full SHA
    1365da9 View commit details
    Browse the repository at this point in the history

  4. removing updates to CHANGELOG.md

    @gfog-floqast
    gfog-floqast authored and greg.fogelberg@floqast.com committed May 31, 2023
    Configuration menu
    Copy the full SHA
    091853a View commit details
    Browse the repository at this point in the history

  5. factors out getUsername and makes requests optional

    @gfog-floqast
    gfog-floqast authored and greg.fogelberg@floqast.com committed May 31, 2023
    Configuration menu
    Copy the full SHA
    b0c6c1f View commit details
    Browse the repository at this point in the history

  6. Fix linting errors

    @jeherve
    jeherve authored and greg.fogelberg@floqast.com committed May 31, 2023
    Configuration menu
    Copy the full SHA
    b3d47e7 View commit details
    Browse the repository at this point in the history

  7. Adjust wording

    @jeherve
    jeherve authored and greg.fogelberg@floqast.com committed May 31, 2023
    Configuration menu
    Copy the full SHA
    0bdada8 View commit details
    Browse the repository at this point in the history

  8. adds missing request param check

    @gfog-floqast
    gfog-floqast authored and greg.fogelberg@floqast.com committed May 31, 2023
    Configuration menu
    Copy the full SHA
    539e82e View commit details
    Browse the repository at this point in the history

  9. requesting the reviews from within the main function

    greg.fogelberg@floqast.com committed May 31, 2023
    Configuration menu
    Copy the full SHA
    a152832 View commit details
    Browse the repository at this point in the history

  10. refactor logic to main

    greg.fogelberg@floqast.com committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f8dc253 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Update projects/github-actions/required-review/changelog/request-revi… 

    …ew-if-not-satisfied

Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
    @gfog-floqast @anomiex
    gfog-floqast and anomiex authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    cdf5650 View commit details
    Browse the repository at this point in the history

  2. Update projects/github-actions/required-review/src/request-review.js 

    Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
    @gfog-floqast @anomiex
    gfog-floqast and anomiex authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    717b41d View commit details
    Browse the repository at this point in the history

  3. Update projects/github-actions/required-review/src/requirement.js 

    Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
    @gfog-floqast @anomiex
    gfog-floqast and anomiex authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    c146f53 View commit details
    Browse the repository at this point in the history

  4. addressing printSet and requirementsMet.length comments

    greg.fogelberg@floqast.com committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    264acb7 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Fix linting errors

    greg.fogelberg@floqast.com committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    e0e1082 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Expected '!=='

    greg.fogelberg@floqast.com committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    6b04ce2 View commit details
    Browse the repository at this point in the history

  2. Update projects/github-actions/required-review/src/request-review.js 

    Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
    @gfog-floqast @anomiex
    gfog-floqast and anomiex authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    49eeaa7 View commit details
    Browse the repository at this point in the history