Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add launchpad navigator to jetpack-mu-wpcom #33045

Closed

Conversation

daledupreez
Copy link
Contributor

@daledupreez daledupreez commented Sep 13, 2023

Fixes #

Proposed changes:

  • This PR explores adding functionality to jetpack-mu-wpcom to show the Launchpad Navigator to users in the editor and wp-admin

There are still a number of TODOs

  • Add and enqueue CSS to better style the task icon
  • Add state handling for showing and hiding the modal - depending on timing, we'll also need to wire in the external state
  • Add icon for the editor context
  • Actually import content from the @automattic/launchpad-navigator package in the Automattic/wp-calypso monorepo.
    • This depends on the package being published from wp-calypso
  • Ensure we align with the standard Jetpack release process/scripts
  • Work out how we can/should package up release content
  • Work out where JS, TS, and CSS source files should live so they aren't included in releases
    • These should probably be pushed into a dedicated js subdirectory (or something similar)
  • Confirm whether want to stick with wp-scripts as the core build tool

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the try/add-launchpad-navigator-to-jetpack-mu-wpcom branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack try/add-launchpad-navigator-to-jetpack-mu-wpcom
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin try/add-launchpad-navigator-to-jetpack-mu-wpcom
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@@ -0,0 +1,12 @@
const defaultConfig = require( '@wordpress/scripts/config/webpack.config' );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other places in the monorepo, we rely on the @automattic/jetpack-webpack-config package we created to properly handle things like i18n:

It may be useful here as well.

@daledupreez daledupreez force-pushed the try/add-launchpad-navigator-to-jetpack-mu-wpcom branch from 54359f7 to f2a8fc8 Compare October 12, 2023 11:32
@daledupreez
Copy link
Contributor Author

Noting for reference that we've picked up the work to add JS/TS build scripts in #34158.

@daledupreez
Copy link
Contributor Author

I am going to close this PR, as we decided not to pursue the launchpad navigator for the time being. See this thread for more context: paYKcK-3CA-p2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants