-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add launchpad navigator to jetpack-mu-wpcom #33045
WIP: add launchpad navigator to jetpack-mu-wpcom #33045
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
@@ -0,0 +1,12 @@ | |||
const defaultConfig = require( '@wordpress/scripts/config/webpack.config' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other places in the monorepo, we rely on the @automattic/jetpack-webpack-config
package we created to properly handle things like i18n:
# Jetpack Webpack Config |
It may be useful here as well.
54359f7
to
f2a8fc8
Compare
Noting for reference that we've picked up the work to add JS/TS build scripts in #34158. |
I am going to close this PR, as we decided not to pursue the launchpad navigator for the time being. See this thread for more context: paYKcK-3CA-p2 |
Fixes #
Proposed changes:
There are still a number of TODOs
@automattic/launchpad-navigator
package in the Automattic/wp-calypso monorepo.wp-calypso
composer.json
js
subdirectory (or something similar)wp-scripts
as the core build toolOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: