Move Jetpack menu position for atomic wp-admin

[candy02058912]

Fixes https://github.com/Automattic/dotcom-forge/issues/5272

Proposed changes:

Before	After

Self-hosted site Jetpack menu position

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Follow the Instructions to test on Atomic/Simple/Jetpack sites: Move Jetpack menu position for atomic wp-admin #35154 (comment)
• Check if the menu is in the correct position for Atomic with the Classic style setting
• Check for other types of sites to see if anything breaks

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/atomic-jetpack-menu-position branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/atomic-jetpack-menu-position
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for February 6, 2024 (scheduled code freeze on February 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[candy02058912]

This seems to return false even if I set to Classic view.

[candy02058912]

Seems like something was broken with my test site: p1706004199390829/1706004045.925339-slack-C06DN6QQVAQ

[candy02058912]

Will need to change this line to parent::add_jetpack_menu( $position, $seperator ); to see the changes mentioned in the PR description.

Update: I've completely changed the approach as modifying the parameters as mentioned in the strikethrough will also mean a change is needed for https://github.com/Automattic/wc-calypso-bridge/blob/master/includes/class-wc-calypso-bridge-ecommerce-admin-menu.php

[candy02058912]

I am aware there is a typo seperator -> separator, which I'll update.
In the meantime, I wanted to get this PR up here to get a review of whether this approach is good or not.

[lupus2k]

It works great and nothing is broken outside wp-admin interface.

[DustyReagan]

Works great!

Just throwing out an option to consider: we could create a new public method in the parent class that takes the position as a parameter to reduce duplicated code. Then we'd call that method in the base parent method and in our method override, so our override would look something like:

public function add_jetpack_menu() {
	// This is supposed to be the same as class-admin-menu but with a different position specified for the Jetpack menu.
	if ( get_option( 'wpcom_admin_interface' ) === 'wp-admin' ) {
		parent::create_jetpack_menu( 2 );
	} else {
		parent::add_jetpack_menu();
	}
}

I'm not sure if we want to do that; I'm just always looking for ways to dedupe code. 😂

[taipeicoder]

Works great 👍

Before	After