-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/jetpack search sort by price default #35167
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Debug Helper plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Search plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
I also tested on WordPress.com simple and works fine there as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works well for me! Thanks for working on this @robfelty 👍
4ef09c1
to
46cb67b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved from #31594
Proposed changes:
Currently it is only possible to set default sort options to newest, oldest, and relevance. Some WooCommerce users would like to be able to also specify a default sort by price or rating. This adds those options to the UI for the Jetpack Search settings.
Other information:
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
To test, spin up a new site with this branch. Look at the Jetpack Search settings. Select "product" as the option for displaying results. You should see the option to set the default sort to price and rating. Choose price, and then perform a search, and check that it is sorted by price by default. If you switch the display back to normal or "expanded", you should no longer see the option to sort by price.