Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Initial support for VideoPress v5 #35637

Merged
merged 24 commits into from
Feb 23, 2024
Merged

[RNMobile] Initial support for VideoPress v5 #35637

merged 24 commits into from
Feb 23, 2024

Commits on Feb 12, 2024

  1. feat: Enable usage of v5's editor component

    Siobhan committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    3b4fe9b View commit details
    Browse the repository at this point in the history

  2. docs: Add changelog entry

    Siobhan committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    07a7b96 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. feat: Dupe Video block for basis of v5 support 

    With this commit, the main Video block files have been duplicated. They will be iterated on in subsequent commits and serve the basis of the changes we'll make to support VideoPress v5.
    Siobhan committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    ea3a0a9 View commit details
    Browse the repository at this point in the history

  2. feat: Fetch VideoPress metadata in edit component 

    The Video block's is refactored to fetch VideoPress metadata, therefore enabling support for v5.
    Siobhan committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    f5e9233 View commit details
    Browse the repository at this point in the history

  3. fix: Ensure plays inline toggle works as expected

    Siobhan committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    79b062d View commit details
    Browse the repository at this point in the history

  4. fix: Remove typo in settings component

    Siobhan committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    6c8d50e View commit details
    Browse the repository at this point in the history

  5. refactor: Update logic for fetching video's URL

    Siobhan committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    87db30a View commit details
    Browse the repository at this point in the history

  6. feat: Ensure poster displays in thumbnail

    Siobhan committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    a5d7df8 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. fix: Ensure isUploadFailed state is always correct

    Siobhan committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    9fecddc View commit details
    Browse the repository at this point in the history

  2. feat: Show activity indicator if video's uploading

    Siobhan committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    92904ee View commit details
    Browse the repository at this point in the history

  3. refactor: Ensure fetchMetadata logic is correct

    Siobhan committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    1aa07e5 View commit details
    Browse the repository at this point in the history

  4. refactor: Call poster directly, no redundant var

    Siobhan committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    1b98f61 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. fix: Return early if GUID is falsey, avoid crash 

    There are times where GUID may be undefined, which leads to a crash in react-native-video.

Details on the crash and further reasoning for this fix can be found here: #35637 (comment)
    Siobhan committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    b4d689c View commit details
    Browse the repository at this point in the history

  2. refactor: Tidy up consts for improved readability

    Siobhan committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    7804db2 View commit details
    Browse the repository at this point in the history

  3. refactor: Replace inline styles with object ref 

    This commit follows the feedback here: #35637 (comment)
    Siobhan committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    85a30ac View commit details
    Browse the repository at this point in the history

  4. refactor: Pass token to support private sites 

    With this commit, the video's token is passed to ensure it can be played back on private sites/videos for both platforms.
    Siobhan committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    11a8a8a View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. Merge branch 'trunk' into rnmobile/support-for-videopress-v5

    Siobhan committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    6c5e18b View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. fix: Return URL for non-VideoPress videos 

    There are instances when the VideoPress code runs despite videos not being converted to VideoPress. For instance, on Jetpack-connected sites with the VideoPress module disabled. To ensure the video block continues to function as expected, we need to return an src for those sites.
    Siobhan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ce02a7c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into rnmobile/support-for-videopress-v5

    Siobhan committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ae25e26 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. fix: Ensure failed state is reset when users retry

    Siobhan committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    1955fc1 View commit details
    Browse the repository at this point in the history

  2. refactor: Tweaks to allow reusing translations 

    The strings used in the block's settings have been tweaked to match the web, so that translations can be reused.
    Siobhan committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    95a7277 View commit details
    Browse the repository at this point in the history

  3. refactor: Align id definition with the video block 

    Addresses feedback here: #35637 (comment)
    Siobhan committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    f1ae7fb View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. feat: Enable embed block convert after URL insert 

    Feedback here: #35637 (comment)
    Siobhan committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e1de824 View commit details
    Browse the repository at this point in the history

  2. refactor: Fix missing period at end of sentence

    Siobhan committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e88d3d4 View commit details
    Browse the repository at this point in the history