Remove old Fly Panel for showing in some scenarios

[lupus2k]

Fixes https://github.com/Automattic/dotcom-forge/issues/6809

Proposed changes:

Old fly panel was showing when clicking on WP & Profile in the masterbar when Jetpack is enabled but SSO is disabled.

Important

This PR should be merged after this diff (D151708-code) is merged since it remove the function of the Fly panel and this PR removes content.

Before:

Screencast.from.2024-06-07.21-25-48.mp4

After:

Screencast.from.2024-06-10.21-50-31.mp4

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Apply this diff: D151708-code
• Sandbox s0.wp.com
• Disable SSO in Jetpack Settings
• Click on W logo
• It should link to My Home at WPcom
• Click on the profile picture
• It should show a fly panel with the Profile & Logout link
• Check if anything is broken on self-hosted sites
• Check if everything works in mobile (Menu open, logout, profile link)
• Check if anything is broken with SSO enabled
• Check if anything is broken with Classic interface is enabled (wp-admin)

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/remove-old-flyout-panel branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/remove-old-flyout-panel
  

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/remove-old-flyout-panel
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for July 2, 2024 (scheduled code freeze on July 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jeherve]

I should note that we last attempted to remove those panels, we had to revert as it was breaking navigation in some scenarios:

#12454
p9Jlb4-R8-p2

Our work on nav-unification may have solved that potential problem on WoA sites, but it may be important to test this change on other self-hosted WordPress sites as well, to ensure we're not removing important options for site owners.

[lupus2k]

Thanks for the info @jeherve

[lupus2k]

I updated the PR, fixing some broken scenarios (like mobile or missing log-out). I also created this diff (D151708-code) with some extra details.

Btw, one test is failing on Github but I can't make it fail locally 🤔

cc @jeherve

[jeherve]

one test is failing on Github but I can't make it fail locally

You'll need to update your PR to latest trunk, that problem should disappear. For more info: #37785

[okmttdhr]

Old fly panel was showing when clicking on WP & Profile in the masterbar when Jetpack is enabled but SSO is disabled.

First, I reproduced the issue described in https://github.com/Automattic/dotcom-forge/issues/6809 on the Atomic Default site but not on Atomic Classic.

After applying the patch, I observed that the issue was resolved ✅.

FWIW, I noticed different behavior on Atomic Classic, which seems appropriate given the differences between Calypso and wp-admin:

• The menu is displayed when hovering over the W icon.
• Clicking the W icon will redirect you to /wp-admin/about.php.

I think this PR need more eyes for;

Check if anything is broken on self-hosted sites
Check if everything works in mobile (Menu open, logout, profile link)
Check if anything is broken with SSO enabled
Check if anything is broken with Classic interface is enabled (wp-admin)

[lupus2k]

FWIW, I noticed different behavior on Atomic Classic, which seems appropriate given the differences between Calypso and wp-admin:

As I understand, we maintain the behavior of non-classic sites.
cc @jeherve @davemart-in

[davemart-in]

I'm not sure I have a strong opinion one way or the other on this one. I could go either way.

[candy02058912]

I'm seeing the old Fly Planel from Default sites only. After applying the patch it is fixed.

Also tested with self-hosted sites to make sure nothing is outright broken.

[allilevine]

I tested with the diff and PR and SSO enabled and disabled, Default and Classic View, self-hosted. I also tested logging out with SSO disabled on Atomic. ✅

[jeherve]

This looks good to me on self-hosted. The current UX in Jetpack latest stable isn't great, and this doesn't really make it worse, so I'd say let's go with it (after a rebase)

[davemart-in]

So excited to finally have this gone! :-)