-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes scrollbar issue if upsell nudge is loaded in sidebar #38170
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue on my end!
My first thought was why we are applying this fix separately from the jitm code itself, but I think that makes sense considering the mutation observer needs to be in place first.
Aside, Im unsure why but I needed to run the mu-wpcom install script as well to test this even though all the file changes seem to be in the masterbar package. 😕 Either way running both install commands for simple tests well.
The one that is actually being used on simple sites when I was testing was the file under fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Szh%2Qcyhtvaf%2Swrgcnpx%2Qzh%2Qjcpbz%2Qcyhtva%2Sfha%2Siraqbe%2Snhgbznggvp%2Swrgcnpx%2Qznfgreone%2Sfep%2Snqzva%2Qzrah%2Spynff%2Qnqzva%2Qzrah.cuc%3Se%3Q399n5258-og, so it's |
98fbf2d
to
25791c3
Compare
Fixes https://github.com/Automattic/dotcom-forge/issues/7936
The bug details and reproduction video are in the original issue.
Before
Nav.scroll.issue.mp4
After
CleanShot.2024-07-03.at.19.35.41.mp4
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
What is being fixed with this PR:
/wp-admin
Note
Test for WoA and Jetpack sites to make sure nothing is broken due to this PR