Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency svelte to v4 #38288

Merged
merged 2 commits into from
Jul 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 94 additions & 33 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Updated package dependencies.
2 changes: 1 addition & 1 deletion projects/js-packages/image-guide/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"rollup-plugin-svelte": "7.2.2",
"rollup-plugin-svelte-svg": "1.0.0-beta.6",
"sass": "1.64.1",
"svelte": "3.58.0",
"svelte": "4.2.18",
"svelte-preprocess": "5.0.4",
"tslib": "2.5.0",
"typescript": "5.0.4",
Expand Down
2 changes: 1 addition & 1 deletion projects/js-packages/image-guide/src/stores/GuideState.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { derived, Writable, writable } from 'svelte/store';
import { derived, writable, type Writable } from 'svelte/store';

/**
* Guide State is a Svelte Store that keeps track
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Writable, Readable, writable, derived } from 'svelte/store';
import { writable, derived, type Writable, type Readable } from 'svelte/store';
import { MeasurableImage } from '../MeasurableImage.js';
import type { Dimensions, Weight } from '../MeasurableImage.js';

Expand Down
1 change: 1 addition & 0 deletions projects/js-packages/image-guide/src/ui/Bubble.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
}
</script>

<!-- eslint-disable-next-line svelte/valid-compile -- Complains about the div needing an ARIA role, but I have no idea what might be correct for this. -->
<div
class="interaction-area {severity}"
bind:this={bubble}
Expand Down
1 change: 1 addition & 0 deletions projects/js-packages/image-guide/src/ui/Main.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
</script>

{#if $guideState === 'active'}
<!-- eslint-disable-next-line svelte/valid-compile -- Complains about the div needing an ARIA role, but I have no idea what might be correct for this. -->
<div
class="guide {size}"
class:show={show !== false}
Expand Down
1 change: 1 addition & 0 deletions projects/js-packages/image-guide/src/ui/Popup.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@

<svelte:window bind:scrollY />
<Portal>
<!-- eslint-disable-next-line svelte/valid-compile -- Complains about the div needing an ARIA role, but I have no idea what might be correct for this. -->
<div
class="jetpack-boost-guide-popup keep-guide-open"
in:fly={{ duration: 150, y: 4, easing: backOut }}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Updated package dependencies.
Loading
Loading