Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync/2may2017 markdown #7107

Merged
merged 4 commits into from
May 24, 2017
Merged

Sync/2may2017 markdown #7107

merged 4 commits into from
May 24, 2017

Conversation

georgestephanis
Copy link
Member

Sync a wpcom changeset from @david-binda over to Jetpack.

Very trivial, just adds a new filter.

@david-binda -- can you provide some information on how it's used so we can have phpdoc for the filter please?

david-binda and others added 3 commits May 2, 2017 19:09
There is an issue with autosaves as they can't be properly restored as the post_content_filtered is not being populated for them.

If someone attempts to restore an autosave, they would get an empty texteditor, as the content is being read from post_content_filtered.

Populating and storing the post_content_filtered even for autosaves addresses this issue.

/z 50817

Merges r134728-wpcom.
This should bring four files into sync with Jetpack's versions. Hurrah!

@see https://[private link]

Merges r148841-wpcom.
@georgestephanis georgestephanis added DO NOT SQUASH Docs [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Dotcom Merge labels May 2, 2017
@georgestephanis georgestephanis self-assigned this May 2, 2017
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, since we already create $post_data['post_content_filtered'] for revisions just a few lines above.

I added the missing docblock. It should be good to merge. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels May 24, 2017
Copy link
Contributor

@david-binda david-binda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @georgestephanis - sorry for the delay here. I somehow missed the ping and got pinged by @jeherve 's follow-up. The comment Jeremy added is about right - it's not a new filter, it has been added in order to fix an issue with missing markup on that field.

@jeherve jeherve merged commit edddd6b into master May 24, 2017
@jeherve jeherve removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 24, 2017
@jeherve jeherve deleted the sync/2may2017-markdown branch May 24, 2017 14:17
jeherve added a commit that referenced this pull request May 29, 2017
eliorivero pushed a commit that referenced this pull request May 30, 2017
* Changelog: first pass at a changelog for 5.0

* Changelog: delete 4.9 testing list.

* Changelog: update minimum WP version to match ver. in jetpack.php

Fixes #7158

* Changelog: add #6051

* Changelog: add #6753

* Changelog: add #6928

* Changelog: add #6964

* Changelog: add #7014

* Changelog: add #7057

* Changelog: add #7060

* Changelog: add #7068

* Changelog: add #7070

* Changelog: add #7072

* Changelog: add #7071

* Changelog: add release date and post shortlink.

* Changelog: add #7094

* Changelog: add #7100

* Changelog: add #7108

* Changelog: add #7113

* Changelog: add #7123

* Changelog: add #7135

* Changelog: add #7143

* Changelog: add #7151

* Changelog: add #6996

* Changelog: add #7105

* Changelog: add #7132

* Changelog: add #7166

* Changelog: fix typo in 4.9 changelog.

* Changelog: remove older releases' changelogs.

@see p1HpG7-42e-p2

* Changelog: add #7090

* Changelog: add #7095

* Changelog: add #7112

* Changelog: add #7115

* Changelog: add #7122

* Changelog: add #7137

* Changelog: add #7138

* Changelog: add #7140

* Changelog: add #7154

* Changelog: add ##7155

* Changelog: add #7163

* Changelog: add #7167

* Changelog: add #7171

* Changelog: add #7180

* Changelog: add #7181

* Changelog: add #7183

* Changelog: add #7184

* Changelog: add #7189

* Changelog: add #7191

* Changelog: add #7193

* Changelog: add #7198

* Changelog: add #7200

* Changelog: add #7209

* Changelog: add #7212

* Testing list: add instructions for #7115

* Changelog: add #7188

* Changelog: add #7205

* Changelog: add #7225

* Changelog: add #6872

* Changelog: add #7107

* Changelog: add #7118

* Changelog: add #7142

* Changelog: add #7170

* Changelog: add #7210

* Changelog: add #7218

* Changelog: add #7232

* Changelog: add #7211

* Changelog: add #7213

* Changelog: add #7229

* Changelog: add #7230

* Changelog: add #7214

* Draft changelog for 5.0

* Changelog updates: 2nd pass at a clearer changelog.

- Fix typos.
- Use consistent tense and tone across all changelog.
- Remove unclear items.

* Changelog: add #7026

* Changelog: add #7058

* Changelog: add #7125

* Changelog: add #7249

* Changelog: add #7185

* add mentions of image widget migration

* Changelog: add info about new output for CLI command.

* Changelog: add WP version number matching the new Image Widget.
JaxsonWang pushed a commit to LuRenJiasWorld/WP-Editor.md that referenced this pull request Jun 1, 2017
shogo82148 pushed a commit to shogo82148/jetpack-markdown that referenced this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants