Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Fix the remove month+year filter link #8327

Merged

Conversation

Viper007Bond
Copy link
Contributor

@Viper007Bond Viper007Bond commented Dec 7, 2017

When filtering by month+year, such as "December 2017", the remove URL for that filter cleared the month and day, not the month and year.

Fixes #8328.

Testing instructions:

  1. Enable search beta.
  2. Enable Jetpack search filter widget.
  3. Enable a month filter using code described here: https://jetpack.com/support/search/customize-search/#basic-facets
  4. Search for something on your test site.
  5. Click on one of the month filters in the widget.
  6. Click the remove filter link for that month.
  7. Verify that the year has been removed from the URL.

Proposed changelog entry for your changes:

Fixed the link that acts as a month and year filter removal toggle on the Search widget

When filtering by month+year, such as "December 2017", the remove URL for that filter cleared the month and day, not the month and year.
@Viper007Bond Viper007Bond added [Feature] Search For all things related to Search [Type] Bug When a feature is broken and / or not performing as intended labels Dec 7, 2017
@Viper007Bond Viper007Bond requested a review from a team as a code owner December 7, 2017 00:18
@Viper007Bond Viper007Bond added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Dec 7, 2017
@jeherve jeherve requested a review from gibrown December 7, 2017 08:44
Copy link
Member

@gibrown gibrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Viper007Bond Viper007Bond merged commit eb3c3e3 into master Dec 8, 2017
@Viper007Bond Viper007Bond deleted the fix/search/clear-year-when-removing-year+month-facet branch December 8, 2017 00:44
@matticbot matticbot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Dec 8, 2017
@oskosk oskosk added this to the 5.7 milestone Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants