Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Page: Only query Rewind status from Jetpack Dashboard if the site is connected #8484

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Admin Page: Only query Rewind status from Jetpack Dashboard if the site is connected #8484

merged 1 commit into from
Jan 8, 2018

Conversation

oskosk
Copy link
Contributor

@oskosk oskosk commented Jan 8, 2018 •
edited
Loading

Avoid an unnecessary query to .com if the site is not yet connected when visisting the Jetpack Admin Page.

Changes proposed in this Pull Request:

  • Checks if site is connected before rendering the QueryRewindStatus component.

Testing instructions:

  • Check this PR on a disconnected site.
  • Build the admin page
  • Visit the Jetpack Dashboard
  • Expect to see no failed request (404 status if the site is brand new. 400 if the site has been connected before being disconnected now) to get rewind status on the network panel.

Proposed changelog entry for your changes:

@oskosk oskosk added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Bug When a feature is broken and / or not performing as intended labels Jan 8, 2018
@oskosk oskosk requested review from enejb and eliorivero January 8, 2018 18:13
@oskosk oskosk requested a review from a team as a code owner January 8, 2018 18:13
@oskosk oskosk added this to the 5.8 milestone Jan 8, 2018
@oskosk oskosk changed the title Rewind: Only query Rewind status from Jetpack Dashboard if the site is connected Admin Page: Only query Rewind status from Jetpack Dashboard if the site is connected Jan 8, 2018
@enejb
Copy link
Member

enejb commented Jan 8, 2018

Make a lot of sense to me. Will test it once it is available via Jetpack Beta

@eliorivero
Copy link
Contributor

This solves the issue 🐑

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 8, 2018
@oskosk
Copy link
Contributor Author

oskosk commented Jan 8, 2018

@enejb it should be available in Jetpack beta now

@enejb enejb mentioned this pull request Jan 8, 2018
Closed
@enejb
Copy link
Member

enejb commented Jan 8, 2018

:shipit:

enejb
enejb approved these changes Jan 8, 2018
View reviewed changes
Copy link
Member

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@oskosk
Copy link
Contributor Author

oskosk commented Jan 8, 2018

Thanks for the review @eliorivero, @enejb !

@oskosk oskosk merged commit 53341c6 into master Jan 8, 2018
@oskosk oskosk deleted the update/check-if-connected-before-querying-rewind-status branch January 8, 2018 22:52
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliorivero eliorivero eliorivero approved these changes

@enejb enejb enejb approved these changes

Assignees
No one assigned
Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
5.8
Development

Successfully merging this pull request may close these issues.
4 participants
@oskosk @enejb @eliorivero @kraftbj