Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: Remove shim for mb_strlen now that the minimum supported PHP version includes it #8869

Closed
wants to merge 1 commit into from

Conversation

oskosk
Copy link
Contributor

@oskosk oskosk commented Feb 17, 2018

Part of #8156.

Alternative to #8868

Fixes https://wordpress.org/support/topic/deprecated-function-create_function-2/

Changes proposed in this Pull Request:

  • Removes the need to shim mb_strlen.

mb_strlen has been available since PHP 4.

Testing instructions:

Proposed changelog entry for your changes:

@oskosk oskosk added this to the 5.9 milestone Feb 17, 2018
@oskosk oskosk requested a review from a team as a code owner February 17, 2018 16:26
@jeherve jeherve mentioned this pull request Feb 17, 2018
13 tasks
@oskosk oskosk changed the title Markdown: Remove shim for mb_strlen now that the minimum supported PHP version includes mb_strlen Markdown: Remove shim for mb_strlen now that the minimum supported PHP version includes it Feb 17, 2018
@oskosk oskosk force-pushed the remove/check-for-mb_strlen branch from 8ac3cce to c2596c7 Compare February 17, 2018 16:28
@oskosk oskosk added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Feb 17, 2018
@oskosk
Copy link
Contributor Author

oskosk commented Feb 17, 2018

Closing in favour of #8868. Turns out that there's still a change that mbstring is not loaded

@oskosk oskosk closed this Feb 17, 2018
@oskosk oskosk removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 17, 2018
@jeherve jeherve deleted the remove/check-for-mb_strlen branch February 19, 2018 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant