-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media Summary: Setup postdata for obtaining the excerpt #9348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraftbj
added
[Type] Bug
When a feature is broken and / or not performing as intended
General
[Status] Needs Review
To request a review from fellow Jetpack developers. Label will be renamed soon.
labels
Apr 18, 2018
oskosk
approved these changes
Apr 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
oskosk
added
[Status] Ready to Merge
Go ahead, you can push that green button!
and removed
[Status] Needs Review
To request a review from fellow Jetpack developers. Label will be renamed soon.
labels
Apr 20, 2018
@kraftbj should we leave an inline note ( |
ghost
removed
the
[Status] Ready to Merge
Go ahead, you can push that green button!
label
Apr 20, 2018
kraftbj
added
the
[Status] Ready to Merge
Go ahead, you can push that green button!
label
Apr 20, 2018
ghost
removed
the
[Status] Ready to Merge
Go ahead, you can push that green button!
label
Apr 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8420
Fixes #9209
Complement of #8510
Supports #8156
In PHP 7.2, warnings are thrown, in the end, because we are attempting to apply
get_the_excerpt
filters without being within the Loop. While Core makes it seem like this should work, it doesn't. (see #8510 for PR that would require Core changes to work as I think it should).In this PR, we override the
$post
global and setup the post data so the excerpt and underlying functions work as intended.We're overriding the
$post
since this function does not presume to operate within the Loop, so we need to fully mock the Loop.Testing instructions: