Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add support for a Tiled Gallery layout (Square Tiles) as a Gutenberg block #9903

Closed
wants to merge 44 commits into from
Closed

Feature: add support for a Tiled Gallery layout (Square Tiles) as a Gutenberg block #9903

wants to merge 44 commits into from

Commits on Jul 12, 2018

  1. prototype separate jetpack tiled gallery block, render in php (placeh… 

    …older), transform to/from core/gallery
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    30f366a View commit details
    Browse the repository at this point in the history

  2. remove dangling comma

    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    0b948f3 View commit details
    Browse the repository at this point in the history

  3. remove php render code - focus on js render (more "Gutenbergy", and u… 

    …nclear on how to store attributes/state so they are available to PHP render)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    72d4f6e View commit details
    Browse the repository at this point in the history

  4. (work in progress - fails gutenberg validation?) render gallery block… 

    … front end, so image state persists (and renders)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    34b7f50 View commit details
    Browse the repository at this point in the history

  5. fix jetpack/gallery attribute definition; attributes were disappearin… 

    …g on editor reload due to assuming wrapper element class name based on core/gallery block (was causing validation error) – fixed by simplifying selector
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    35e2612 View commit details
    Browse the repository at this point in the history

  6. refactor jetpack/gallery to use same component for rendering images i… 

    …n save and edit
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    af8991d View commit details
    Browse the repository at this point in the history

  7. implement column-tiled jetpack/gallery using css column-count approach

    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    6816e28 View commit details
    Browse the repository at this point in the history

  8. tweak styling so gallery layout is consistent across editor/frontend: 

    - reset line-height
- zero out figure margin
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    6cfe3cb View commit details
    Browse the repository at this point in the history

  9. fix jetpack gallery transform to/from core gallery: correctly pass at… 

    …tributes object
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    174271c View commit details
    Browse the repository at this point in the history

  10. add upload button prompt text

    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    2217959 View commit details
    Browse the repository at this point in the history

  11. basic gallery item item component - rough markup (port php tiled gall… 

    …ery to js work-in-progress)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    cdc0bf9 View commit details
    Browse the repository at this point in the history

  12. update classname in attribute spec to ensure block attributes are pre… 

    …served (fix no data/validation error)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    3eaea6f View commit details
    Browse the repository at this point in the history

  13. get image dimensions from store/api and render in markup

    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    0bdd760 View commit details
    Browse the repository at this point in the history

  14. ensure that all child TiledGalleryItems have a key

    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    01979a4 View commit details
    Browse the repository at this point in the history

  15. set width & height attributes and render them in front-end markup (so… 

    … we can use them for smart tiling layouts implemented in js)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    c705d05 View commit details
    Browse the repository at this point in the history

  16. add columns attribute (param for various tiled layouts)

    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    f468a92 View commit details
    Browse the repository at this point in the history

  17. enqueue tiled gallery js (and css) by default, so we can use it for o… 

    …ur block-based tiled galleries (short term hack)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    18e3301 View commit details
    Browse the repository at this point in the history

  18. remove width/height elements from visible display (remnant of dev/inv… 

    …estigation)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    82b840a View commit details
    Browse the repository at this point in the history

  19. new placeholder react component for "Square Tiles" layout, use it by … 

    …default
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    6589f07 View commit details
    Browse the repository at this point in the history

  20. initial port of square tiled layout algorithm – rough markup structure

    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    81773dc View commit details
    Browse the repository at this point in the history

  21. remove jetpack-tiled-gallery class to avoid clashes with column-count… 

    … fake masonry prototype styles
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    f5466c7 View commit details
    Browse the repository at this point in the history

  22. square layout roughly working – render calculated layout width as sty… 

    …le attribute (big cells are not working right yet)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    4ff864f View commit details
    Browse the repository at this point in the history

  23. hard code content width to 520 for now (is appropriate for my current… 

    … setup) so initial layout is roughly correct
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    505c4c9 View commit details
    Browse the repository at this point in the history

  24. implement basic square-tiles layout - render appropriate classes and … 

    …size-related attributes expected by tiled-gallery.js resize script
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    97b9e68 View commit details
    Browse the repository at this point in the history

  25. fix tiled-gallery image spacing – override (reset) figure margin

    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    6126491 View commit details
    Browse the repository at this point in the history

  26. capitalise tiled gallery block "save" component, consistent with othe… 

    …r components
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    a1e0d02 View commit details
    Browse the repository at this point in the history

  27. check setAttributes prop in TiledGalleryImage before use

    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    cabb462 View commit details
    Browse the repository at this point in the history

  28. WYSIWYG editor preview for jetpack tiled galleries in Gutenberg editor 

    - use full save component rather than rendering individual image tiles
- note this uses the existing jQuery setup/resize handling script and css
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    b525bc4 View commit details
    Browse the repository at this point in the history

  29. remove tiled gallery block file upload button (until we find a nice w… 

    …ay to integrate it as a proto-image tiles)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    31430d1 View commit details
    Browse the repository at this point in the history

  30. enqueue existing/legacy tiled gallery scripts & styles for in `enqueu… 

    …e_block_assets` for use in gutenberg editor and front end (fix hack enqueue in constructor)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    25bd5fb View commit details
    Browse the repository at this point in the history

  31. Gutenberg Tiled Gallery: add support for editing column count attribu… 

    …te (first cut)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    250b3e4 View commit details
    Browse the repository at this point in the history

  32. Gutenberg Tiled Gallery: fix issue with column count not displaying i… 

    …n editor
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    fb13e61 View commit details
    Browse the repository at this point in the history

  33. Gutenberg Tiled Gallery: render captions if they are set for the imag… 

    …e (media item) (using exisiting tiled galleries css, rather than gutenberg style)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    13c974f View commit details
    Browse the repository at this point in the history

  34. Gutenberg Tiled Gallery: implement "link to.." author option ("..atta… 

    …chment page" not working yet)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    0ca6533 View commit details
    Browse the repository at this point in the history

  35. Gutenberg Tiled Gallery: fix "link to..attachment page" - link prop… 

    …erty was not persisted to attributes
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    7259673 View commit details
    Browse the repository at this point in the history

  36. Gutenberg Tiled Gallery: tidy up edit component, remove methods that … 

    …we don't use (that we stole from core/gallery..)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    f65f730 View commit details
    Browse the repository at this point in the history

  37. Gutenberg Tiled Gallery: disable linkTo when editing, to avoid risk o… 

    …f user navigating out of editor when clicking the gallery
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    c77d9a2 View commit details
    Browse the repository at this point in the history

  38. Gutenberg Tiled Gallery: remove style.css (unused, left over from col… 

    …umn-count layout experiment)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    f3d33bc View commit details
    Browse the repository at this point in the history

  39. Gutenberg Tiled Gallery: remove unused image component

    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    9ccc306 View commit details
    Browse the repository at this point in the history

  40. Gutenberg Tiled Gallery: switch out album icon for format-gallery… 

    … (for now - ideally we'd have a jetpack-branded icon or a "tiled" icon)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    223ff77 View commit details
    Browse the repository at this point in the history

  41. Gutenberg Tiled Gallery: consistent capitalisation for save component

    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    766105b View commit details
    Browse the repository at this point in the history

  42. Gutenberg Tiled Gallery: tidy/clarify comments

    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    843bcfd View commit details
    Browse the repository at this point in the history

  43. Gutenberg Tiled Gallery: avoid fragile relative paths when enqueing g… 

    …utenberg script asset (using JETPACK__PLUGIN_FILE instead of current-file-relative __FILE__)
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    309baa5 View commit details
    Browse the repository at this point in the history

  44. Gutenberg Tiled Gallery: use "Jetpack Gallery" in empty-gallery place… 

    …holder component for consistency and to disambiguate from core/gallery
    @haszari @ockham
    haszari authored and ockham committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    f0efb90 View commit details
    Browse the repository at this point in the history