Allow exponential backoff to cap its delay at an specified maximum #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like the tests that are not passing weren't passing before my patch either, should I rebase this to a stable commit with passing tests, wait for you to fix the tests, or something else? |
|
seems like there hasn't been a commit from a maintainer in 3 months, maybe this project is now dead? |
|
@Darkhogg Would ya rebase please? |
|
Rebased to |
|
Is there any chance of this PR (and other recent merged PRs) making to npm in the foreseeable future? |
|
Sure, I should release a patch version & publish it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a new argument in the backoff object,
maxDelay, which caps the delay that a failed attempt will have when using exponential backoff.Fixes #1025