Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delay() can now accept a future date at which run the job #497

Merged
merged 2 commits into from
Feb 11, 2015
Merged

delay() can now accept a future date at which run the job #497

merged 2 commits into from
Feb 11, 2015

Conversation

ItalyPaleAle
Copy link
Contributor

It's now possible to pass a Date object to delay() with a future date in time instead of a number of ms.

@yocontra
Copy link

Yess I've wanted this for so long. What needs to get done to merge this?

@behrad
Copy link
Collaborator

behrad commented Feb 11, 2015

I've not had enough time to make 0.9.0 release ready... will look into this ASAP @contra
actually I was planned it for the Feb. 28th https://github.com/LearnBoost/kue/milestones

@yocontra
Copy link

@behrad Any reason you can't merge things into a new 0.9.0 branch as they become completed, then publish when ready? It would allow people to test out the new 0.9.0 features and provide feedback before the release

@ItalyPaleAle
Copy link
Contributor Author

:+1 +1 for this change in the way to operate. Eventually, it's common for the master branch to be more "cutting edge" (and tags exist for this reason!)

Right now, my project is configured with NPM pointing at my own fork. As you can imagine, it's not ideal

@yocontra
Copy link

@EgoAleSum Right now my project is configured to your fork too 😄

@behrad
Copy link
Collaborator

behrad commented Feb 11, 2015

Sorry guys for the delay...

behrad added a commit that referenced this pull request Feb 11, 2015
delay() can now accept a future date at which run the job
@behrad behrad merged commit 3bb79fc into Automattic:master Feb 11, 2015
@ItalyPaleAle
Copy link
Contributor Author

Thank you! Can you also please merge either #500 or #334 ? In particular, #334 has been there for 9 months! (the two patches are very similar)

@behrad
Copy link
Collaborator

behrad commented Feb 11, 2015

sure, I will merge that feature in a day or two :)

@ItalyPaleAle ItalyPaleAle deleted the delay-date branch February 11, 2015 21:46
@ItalyPaleAle
Copy link
Contributor Author

@behrad sorry to bother you... Any news about merging the other patches?

@behrad
Copy link
Collaborator

behrad commented Feb 24, 2015

I'll try to merge some this Thursday @EgoAleSum

@ItalyPaleAle
Copy link
Contributor Author

@behrad we're all here hanging off your words :)

@behrad
Copy link
Collaborator

behrad commented Mar 5, 2015

This is very embarrassing I know, gonna close this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants