Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store multiple instances of jobs in jobs id map to emit events for all #750

Merged
merged 1 commit into from
May 13, 2016

Conversation

mojojoji
Copy link
Contributor

Fixes issue #749

@behrad
Copy link
Collaborator

behrad commented Nov 11, 2015

Thank you @jojihere
Have you checked if Job.get reaches events.add so that fetched jobs gets into events list?

@behrad behrad added the Feature label Nov 11, 2015
@mojojoji
Copy link
Contributor Author

events.add() is not getting called on Job.get(). I have found a subscribe function that does this.
This following merge added that Allow job to be subscribed for event mapping #139
But that only fires for the first job instance created and subscribed as the jobs are stored in a map with key as job id and value the instance of job. I have changed this to key as job id and value as array of job instances. And emit is called for all the instances in this map

@behrad
Copy link
Collaborator

behrad commented Nov 19, 2015

I'm ready to merge this, Can you add related test so that I merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants