Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern Node.js versions support #812

Merged
merged 4 commits into from
May 13, 2016

Conversation

kerimdzhanov
Copy link
Contributor

Node.js currently supports v4.2.6 LTS and v5.5.0 Latest Stable, let's make tests run against them in Travis.

@behrad
Copy link
Collaborator

behrad commented Jan 25, 2016

Something is failing @kerimdzhanov ?

Can you also add 0.12?

@kerimdzhanov
Copy link
Contributor Author

On my local machine all versions was success, i will check.

Regarding to the v0.12, I also think it should be added 👍.

@kerimdzhanov
Copy link
Contributor Author

Something strange with Queue#shutdown, sometimes tests passed sometimes not.

Take a look at my build: https://travis-ci.org/kerimdzhanov/kue

@kerimdzhanov
Copy link
Contributor Author

This error happens very rare and not depending on the Node.js version.
I'm trying to catch it...

@kerimdzhanov
Copy link
Contributor Author

I've done with catching the errors. As I already wrote, they not depending on the Node.js version, so I sent it in another PR #813 (I suggest to merge it first).

Regarding to this PR, you can "Restart" the build on Travis and it most likely will be successful.

It happens rarely, I'm just lucky ;)

@behrad behrad merged commit 751b2b6 into Automattic:master May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants