Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mongoose): make setDriver() update mongoose.model() connections and collections #14505

Merged
merged 3 commits into from
Apr 7, 2024
Merged

fix(mongoose): make setDriver() update mongoose.model() connections and collections #14505

merged 3 commits into from
Apr 7, 2024

Conversation

vkarpov15
Copy link
Collaborator

Summary

Right now calling setDriver() after mongoose.model() leaves models in an inconsistent state where they point to the old default connection and collections derived from the old default connection.

Examples

hasezoey
hasezoey approved these changes Apr 6, 2024
View reviewed changes
lib/model.js Outdated Show resolved Hide resolved
@vkarpov15 vkarpov15 added this to the 8.3.1 milestone Apr 7, 2024
@vkarpov15 vkarpov15 merged commit 7cf76cc into master Apr 7, 2024
34 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/set-driver-model-db-2 branch April 7, 2024 21:34
@Marion-Rld Marion-Rld mentioned this pull request May 18, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request May 19, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 19, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request May 19, 2024
Open
@YohanChabiduPerera YohanChabiduPerera mentioned this pull request May 19, 2024
Open
@akanchhaS akanchhaS mentioned this pull request May 19, 2024
Open
@Erenkrs Erenkrs mentioned this pull request May 19, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request May 20, 2024
Open
@lholmquist lholmquist mentioned this pull request May 20, 2024
Closed
@Erenkrs Erenkrs mentioned this pull request May 20, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 20, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request May 21, 2024
Open
@akanchhaS akanchhaS mentioned this pull request May 21, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request May 21, 2024
Open
@shazamakash1 shazamakash1 mentioned this pull request May 22, 2024
Open
@mihirhbhatt mihirhbhatt mentioned this pull request May 22, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request May 22, 2024
Open
@IdrizMirena IdrizMirena mentioned this pull request May 22, 2024
Open
@olexiyb olexiyb mentioned this pull request May 22, 2024
Closed
@nhattpn nhattpn mentioned this pull request May 23, 2024
Closed
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request May 24, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request May 24, 2024
Open
@Erenkrs Erenkrs mentioned this pull request May 24, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request May 24, 2024
Open
@Erenkrs Erenkrs mentioned this pull request May 26, 2024
Open
@boytur boytur mentioned this pull request May 26, 2024
Open
This was referenced May 26, 2024
Open
Open
@akanchhaS akanchhaS mentioned this pull request May 27, 2024
Open
@Safar123 Safar123 mentioned this pull request May 28, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 28, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request May 28, 2024
Open
@boytur boytur mentioned this pull request May 28, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request May 28, 2024
Open
@Erenkrs Erenkrs mentioned this pull request May 29, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request May 29, 2024
Open
@nhattpn nhattpn mentioned this pull request May 29, 2024
Closed
@Erenkrs Erenkrs mentioned this pull request May 29, 2024
Open
@lholmquist lholmquist mentioned this pull request May 30, 2024
Closed
@hatifmujahid hatifmujahid mentioned this pull request May 30, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request May 30, 2024
Open
@pasang7 pasang7 mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@vkarpov15 @hasezoey