-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add null
to select
override return type for findOne
#14545
Merged
vkarpov15
merged 1 commit into
Automattic:master
from
sderrow:fix-select-override-return-type
Apr 29, 2024
Merged
Add null
to select
override return type for findOne
#14545
vkarpov15
merged 1 commit into
Automattic:master
from
sderrow:fix-select-override-return-type
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll make some lint fixes and add tests in master but code looks good.
vkarpov15
added a commit
that referenced
this pull request
Apr 29, 2024
This was referenced May 21, 2024
This was referenced May 21, 2024
Merged
This was referenced May 21, 2024
This was referenced Jun 7, 2024
This was referenced Jun 9, 2024
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Normally, a
findOne
orfindById
returnsDocType | null
. When usingQuery.prototype.select
, we can provide aRawDocTypeOverride
in order to define the true return type of the projected document. Currently, this makesfindOne
andfind
queries returnRawDocTypeOverride
directly, but in order to be consistent, it should returnRawDocTypeOverride | null
.This is consistent with how you don't currently have to specify the array version for
find
; that method automatically returns the array version ofRawDocTypeOverride
. Therefore,select
onfindOne
should return the nullable version ofRawDocTypeOverride
automatically.Examples