remove old benchmarks, add new benchmark for #14394 #14626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the benchmarks dir is filled with old benchmarks that haven't been maintained since 2013. Given that we're looking to focus more on performance, we should remove the stale benchmarks and instead start building out a new benchmark suite based on benchmarks we've found useful, like #14394.
Here are some priorities for new benchmarks:
MONGOOSE_BENCHMARK_SKIP_SETUP
environment variable. Also for flamegraphs, as well as faster iteration.perf.mongoosejs.io
or something similar that shows Mongoose's performance on benchmarks over time.Examples