Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(connection): make transaction() return type match the executor function #14661

Merged
merged 5 commits into from
Jun 11, 2024
Merged

types(connection): make transaction() return type match the executor function #14661

merged 5 commits into from
Jun 11, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14656

Summary

In MongoDB driver 6.x, withTransaction() now returns the executor function's return value. Mongoose should match that change.

Examples

@vkarpov15 vkarpov15 added this to the 8.5 milestone Jun 10, 2024
hasezoey
hasezoey approved these changes Jun 11, 2024
View reviewed changes
test/types/connection.test.ts Outdated Show resolved Hide resolved
@vkarpov15 @hasezoey
Update test/types/connection.test.ts
90a2b5d 
Co-authored-by: hasezoey <hasezoey@gmail.com>
@vkarpov15 vkarpov15 changed the base branch from master to 8.5 June 11, 2024 21:48
@vkarpov15 vkarpov15 merged commit 90fa8af into 8.5 Jun 11, 2024
27 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-14656 branch June 12, 2024 05:07
@akanchhaS akanchhaS mentioned this pull request Jul 30, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jul 30, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Jul 30, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Jul 30, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Jul 30, 2024
Open
@k2xl k2xl mentioned this pull request Jul 30, 2024
Closed
@carltrepanier carltrepanier mentioned this pull request Jul 30, 2024
Merged
@ilovepixelart ilovepixelart mentioned this pull request Jul 30, 2024
Closed
@MihikaNigam MihikaNigam mentioned this pull request Jul 30, 2024
Open
This was referenced Jul 30, 2024
Closed
Closed
This was referenced Jul 30, 2024
Open
Open
Open
@vky5 vky5 mentioned this pull request Jul 30, 2024
Closed
@clifford-snyk-github clifford-snyk-github mentioned this pull request Jul 31, 2024
Closed
@bakiUru bakiUru mentioned this pull request Jul 31, 2024
Open
@Eduardo-Cozer Eduardo-Cozer mentioned this pull request Aug 2, 2024
Open
This was referenced Sep 1, 2024
Open
Open
@nejidevelops nejidevelops mentioned this pull request Sep 2, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Sep 3, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 3, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 3, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Sep 3, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 3, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Sep 3, 2024
Open
This was referenced Sep 3, 2024
Open
Open
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Sep 3, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 4, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Sep 4, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 4, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Sep 4, 2024
Open
@lholmquist lholmquist mentioned this pull request Sep 4, 2024
Closed
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 4, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 4, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Sep 4, 2024
Open
This was referenced Sep 4, 2024
Open
Open
Open
@MihikaNigam MihikaNigam mentioned this pull request Sep 4, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 4, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 6, 2024
Open
@GoGPenguin GoGPenguin mentioned this pull request Sep 6, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 6, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5
Development

Successfully merging this pull request may close these issues.

The return type of connection.tranaction method should not be Promise<void>.
3 participants
@vkarpov15 @hasezoey @futurliberta