Remove default connection if setting createInitialConnection to false after Mongoose instance created #14679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
approved these changes
Jun 24, 2024
hasezoey
approved these changes
Jun 24, 2024
Co-authored-by: hasezoey <hasezoey@gmail.com>
This was referenced Jul 30, 2024
This was referenced Jul 30, 2024
This was referenced Sep 1, 2024
This was referenced Sep 3, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now there's always a default
mongoose.connection. We added acreateInitialConnectionoption that prevents newMongooseinstances from creating a default connection, but that doesn't apply to existingMongooseinstances, including the default one. So there's no way to really "delete" the default connection in the API.With this PR,
mongoose.set('createInitialConnection', false)will also remove the default connection, presuming it isn't connected and there are no models already on it.Examples