Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(connection): fix return type of withSession() #14690

Merged
merged 2 commits into from
Jun 25, 2024
Merged

types(connection): fix return type of withSession() #14690

merged 2 commits into from
Jun 25, 2024

Conversation

tt-public
Copy link
Contributor

Summary

This fixes Connection.withSession()'s type definition, which currently doesn't seem to match the implementation [here].

Examples

(a test is added instead)

vkarpov15
vkarpov15 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 8.4.4 milestone Jun 25, 2024
@vkarpov15 vkarpov15 merged commit f89868b into Automattic:master Jun 25, 2024
3 checks passed
This was referenced Jul 16, 2024
Closed
Merged
@issam-seghir issam-seghir mentioned this pull request Jul 17, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jul 17, 2024
Open
@jfnw-capco jfnw-capco mentioned this pull request Jul 17, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Jul 17, 2024
Open
@bryopsida bryopsida mentioned this pull request Jul 17, 2024
Closed
@NotZarifGithub NotZarifGithub mentioned this pull request Jul 17, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jul 17, 2024
Open
This was referenced Jul 17, 2024
Merged
Merged
@jahidhasan1893 jahidhasan1893 mentioned this pull request Jul 17, 2024
Open
@DaveLuhman DaveLuhman mentioned this pull request Jul 17, 2024
Closed
@axqqt axqqt mentioned this pull request Jul 17, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Jul 17, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 17, 2024
Open
@lholmquist lholmquist mentioned this pull request Jul 17, 2024
Closed
@carltrepanier carltrepanier mentioned this pull request Jul 17, 2024
Merged
This was referenced Jul 17, 2024
Open
Open
@WontonSam WontonSam mentioned this pull request Jul 17, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Jul 18, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jul 18, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Jul 18, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Jul 18, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Aug 20, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 20, 2024
Open
@zntb zntb mentioned this pull request Aug 21, 2024
Merged
@issam-seghir issam-seghir mentioned this pull request Aug 21, 2024
Open
@zntb zntb mentioned this pull request Aug 21, 2024
Closed
@akanchhaS akanchhaS mentioned this pull request Aug 21, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Aug 21, 2024
Open
@lholmquist lholmquist mentioned this pull request Aug 21, 2024
Closed
@NotZarifGithub NotZarifGithub mentioned this pull request Aug 21, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Aug 21, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Aug 21, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 21, 2024
Open
Open
Open
@MihikaNigam MihikaNigam mentioned this pull request Aug 21, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Aug 21, 2024
Open
@WontonSam WontonSam mentioned this pull request Aug 21, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Aug 22, 2024
Open
@nostoc nostoc mentioned this pull request Aug 22, 2024
Open
This was referenced Aug 23, 2024
Open
Open
@Erenkrs Erenkrs mentioned this pull request Aug 23, 2024
Open
@H1B0B0 H1B0B0 mentioned this pull request Aug 23, 2024
Merged
This was referenced Aug 24, 2024
Open
Open
@itsarraj itsarraj mentioned this pull request Aug 26, 2024
Open
This was referenced Aug 26, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@tt-public @vkarpov15