-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvements for insertMany()
#14724
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billouboq
reviewed
Jul 9, 2024
hasezoey
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, one minor suggestion
This was referenced Aug 2, 2024
This was referenced Sep 4, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The big changes are:
_skipParallelValidateCheck
option forvalidate()
. Looks like creating a newParallelValidateError()
each time is relatively expensive, and unnecessary forinsertMany()
since the user won't have access to the document references anyway outside of middleware.$toObject()
in favor of$__toObjectInternal()
, which skips options processing and only does a shallow clone, when usinginsertMany()
on documents which only have primitive values (no subdocs, nested paths, or arrays).Before this PR:
After this PR:
Looking at about 2.5x performance improvement.
Potential alternative would be to change
this.$__.validating
to use a boolean instead of an error instance, will investigate.Examples