Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine query selector to highlight unexpected query keys #14764

Merged
merged 7 commits into from
Aug 12, 2024
Merged

Refine query selector to highlight unexpected query keys #14764

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
330dd36
Refine query selector to highlight unexpected query keys
alex-statsig Jul 26, 2024
ea2a4ef
Add separate RootFilterQuery to type some cases better, add test cases
alex-statsig Aug 3, 2024
b810a9d
Fix new typescript error assertions
alex-statsig Aug 5, 2024
baf3ca2
Fix one more ts-expect-error to use expectError
alex-statsig Aug 5, 2024
50b26dc
Merge branch '8.6' into patch-1
vkarpov15 Aug 10, 2024
8d6422b
Update models.d.ts
vkarpov15 Aug 10, 2024
e5c9b7b
Fix queryhelpers test
alex-statsig Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions types/query.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,9 @@ declare module 'mongoose' {
/** @see https://www.mongodb.com/docs/manual/reference/operator/query/comment/#op._S_comment */
$comment?: string;
// we could not find a proper TypeScript generic to support nested queries e.g. 'user.friends.name'
// this will mark all unrecognized properties as any (including nested queries)
[key: string]: any;
// this will mark all unrecognized properties as any (including nested queries) only if
// they include a "." (to avoid generically allowing any unexpected keys)
[nestedSelector: `${string}.${string}`]: any;
};

interface QueryTimestampsConfig {
Expand Down
Loading